From: Roman Zippel <zippel@xs4all.nl>
To: Robert Love <rml@tech9.net>
Cc: nigel@nrg.org, george anzinger <george@mvista.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] improve spinlock debugging
Date: Wed, 05 Dec 2001 02:13:28 +0100 [thread overview]
Message-ID: <3C0D74B8.F3FF439@xs4all.nl> (raw)
In-Reply-To: <Pine.LNX.4.40.0112041321080.595-100000@cosmic.nrg.org> <1007504598.1307.30.camel@phantasy>
Hi,
Robert Love wrote:
> Right, I meant just the spin_lock_irq case, which would be fine except
> for the case where:
>
> spin_lock_irq
> spin_unlock
> restore_irq
>
> to solve this, we need a spin_unlock_irq_on macro that didn't touch the
> preemption count.
Has someone a real example of something like this?
I'd suspect someone is trying a (questionable) micro optimization or is
holding the lock for too long anyway. Instead of adding more macros,
maybe it's better to look closely whether something needs fixing.
bye, Roman
next prev parent reply other threads:[~2001-12-05 1:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-03 20:10 [PATCH] improve spinlock debugging Manfred Spraul
2001-12-04 4:21 ` David S. Miller
2001-12-04 4:30 ` Robert Love
2001-12-04 20:30 ` george anzinger
2001-12-04 20:51 ` Robert Love
2001-12-04 21:25 ` george anzinger
2001-12-04 21:39 ` Robert Love
2001-12-04 22:06 ` Nigel Gamble
2001-12-04 22:23 ` Robert Love
2001-12-05 1:13 ` Roman Zippel [this message]
2001-12-05 7:41 ` george anzinger
2001-12-04 20:53 ` Manfred Spraul
2001-12-05 0:54 ` george anzinger
2001-12-04 21:20 ` Nigel Gamble
2001-12-04 21:27 ` george anzinger
2001-12-05 8:47 ` Giuliano Pochini
2001-12-05 15:42 ` Manfred Spraul
[not found] ` <20011219025332.GA18344@krispykreme>
2001-12-20 17:08 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D74B8.F3FF439@xs4all.nl \
--to=zippel@xs4all.nl \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nrg.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox