From: Michael Clark <michael@metaparadigm.com>
To: Rob Myers <rob.myers@gtri.gatech.edu>
Cc: LKML <linux-kernel@vger.kernel.org>, Benjamin LaHaise <bcrl@redhat.com>
Subject: Re: [PATCH] - 2.4.16 ns83820 optical support (Netgear GA621)
Date: Wed, 05 Dec 2001 09:48:26 +0800 [thread overview]
Message-ID: <3C0D7CEA.2050307@metaparadigm.com> (raw)
In-Reply-To: <3C0CED3B.7030409@metaparadigm.com> <1007501048.14051.28.camel@ransom>
Rob Myers wrote:
> cool, i've tested your patch and it seems to work. now i will be free
> of that unfriendly netgear driver. :) i tested it on an updated redhat
> 7.2 box. (2.4.9-13smp) it is an asus p2b-d motherboard. (p3 smp,
> 32bitpci).
>
> i did notice some odd dmesg output, however:
>
> eth%d: enabling 64 bit PCI.
> eth%d: enabling optical transceiver
> eth1: ns83820.c v0.13: DP83820 00:40:f4:29:ea:d7 pciaddr=0xe1000000
> irq=12 rev 0x103
> eth1: link now 1000F mbps, full duplex and up.
> eth1: link now 1000F mbps, full duplex and up.
>
> [now keeping in mind i know nothing of linux device drivers...]
>
> this is only a 32bit pci box so why would it enable 64bit pci?
The code reads a 64bit detect flag from the ns chip - so I guess it
must be bogus with some motherboards. Mine is okay. Ben??
> are references to dev->net_dev.name valid before
> register_netdev(&dev->net_dev) in ns83820_init_one()?
Okay, so i'll move the register_netdev call earlier on in the
initialisation and add any necessary unregister call for failures.
> is/why phy_intr() called 2wice?
The card issues multiple interrupts during auto-negotiation. If you
change the dprintk to a printk on the line with the tbisr=, tanar=,
you'll see the details of the phy interrupt. The driver needs a link
status variable so we then only print link status changes when
link status changes. The current problem is purely cosmetic.
> thanks for the patch!
>
> rob.
next prev parent reply other threads:[~2001-12-05 1:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-04 15:35 [PATCH] - 2.4.16 ns83820 optical support (Netgear GA621) Michael Clark
2001-12-04 21:24 ` Rob Myers
2001-12-04 21:31 ` Jeff Garzik
2001-12-05 1:48 ` Michael Clark [this message]
2001-12-05 5:02 ` Michael Clark
2001-12-05 12:55 ` Jeff Garzik
2001-12-05 14:37 ` Michael Clark
2001-12-05 16:56 ` Rob Myers
2001-12-05 22:50 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D7CEA.2050307@metaparadigm.com \
--to=michael@metaparadigm.com \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.myers@gtri.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox