From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Eric Lammerts <eric@lammerts.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@zip.com.au>, Josh McKinney <forming@home.com>,
linux-kernel@vger.kernel.org
Subject: Re: Fwd: binutils in debian unstable is broken.
Date: Wed, 05 Dec 2001 09:18:34 -0500 [thread overview]
Message-ID: <3C0E2CBA.57412C69@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.43.0112051424560.1157-100000@ally.lammerts.org>
Eric Lammerts wrote:
> change the drivers like this:
>
> #ifdef DEVEXIT_LINKED
> remove: firestream_remove_one,
> #endif
>
> to this:
>
> remove: DEVEXIT_FUNC(firestream_remove_one),
The overall situation is not great, but I think I prefer this, or
something like this, to the ifdef.
I'm tempted to say we should add a per-driver function that calls BUG()
instead of a generic function which calls panic(), though. That will be
a bit more informative to users. For the case where the real
xxx_remove_one is dropped, it is a kernel bug if that code is -ever-
called...
Jeff
--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno
next prev parent reply other threads:[~2001-12-05 14:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-05 5:05 Fwd: binutils in debian unstable is broken Josh McKinney
2001-12-05 5:20 ` Daniel T. Chen
2001-12-05 5:42 ` Andrew Morton
2001-12-05 6:41 ` Andrew Morton
2001-12-05 9:37 ` eddantes
2001-12-05 10:58 ` Mike Fedyk
2001-12-05 8:43 ` Alan Cox
2001-12-05 9:49 ` Jakub Jelinek
2001-12-05 13:34 ` Eric Lammerts
2001-12-05 14:18 ` Jeff Garzik [this message]
2001-12-06 15:09 ` Kai Germaschewski
2001-12-05 14:38 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2001-12-05 5:19 Frédéric L. W. Meunier
2001-12-05 5:25 ` Daniel T. Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0E2CBA.57412C69@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eric@lammerts.org \
--cc=forming@home.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox