Re: release() locking

[Andrew Morton <akpm@zip.com.au>]

"Udo A. Steinberg" wrote:
> 
> Hi Andrew,
> 
> According to Linus' 2.5.1-pre changelog, the release locking changes
> introduced in -pre5 are your work. Those changes, however, seem to
> break the keyboard driver:
> 
> keyboard: Timeout - AT keyboard not present?(f4)
> 
> Other people (i.e. Mike Galbraith) have been experiencing the same.

wasntmeididntdoit

> Do you have an updated patch which fixes those issues? -pre6 still
> contains the same stuff as -pre5 and if it's broken then Linus should
> probably back it out.

My patch simply fixed a few things like holding spinlocks across
sleeping functions, forgetting to release locks when returning
from functions, etc.

Yes, others have suggested that the whole lot should be reverted,
for several reasons.  However it looks like that won't happen, so we
need to debug the present code.  But it works for me.

I can review the code, see if anything stands out.  But it'll probably
require someone who can reproduce it to be able to fix it.

-