Re: dscc4 and new Generic HDLC Layer

[Daniela Squassoni <daniela@cyclades.com>]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

Bob Dunlop wrote:
> 
> I'm confused.  How was the patch generated ?   How should I apply it ?
> 
> The patch repeats some of Krzystofs changes so I can't apply it over the
> top of his patch but at the same time it doesn't include the changes for
> FarSite, SBE Inc or you own Cyclades cards.  Better to have a patch that
> brings all the drivers up to spec in one hit surely.

This patch was done against the kernel 2.4.17-pre8. All the drivers that
are using the HDLC layer in the kernel source tree have been included.
The farsync.c does not even call the register_hdlc_device routine... 

Let's fix what is already in the kernel source tree first, and then we
can include what is missing (e.g. the PC300 driver and others that
provide separate patches for the HDLC layer), right?!

> 
> Probably too late to get API changes into 2.4.x, but we should get the
> generic HDLC layer into 2.5.x ASAP IMHO.  Then you might be able to argue
> for a backport into 2.4.x in the future.

Why doing that if it is ready for 2.4.x?!
The patch that I've just sent doesn't bring anything really new. It just
fixes what is wrong in the current version. Am I missing something here?

> 
> > I am waiting for the inclusion of these changes in the kernel for months
> > to submmit the PC300 driver, and this delay is causing me troubles,
> > customers complainings, etc.
> 
> Tell me about it :-)  FarSite are having to maintain an extra set of patches
> for customers who need the functionality of the generic layer.
That is exactly what I have to do...

Best regards,

Daniela

[-- Attachment #2: Card for Daniela Squassoni --]
[-- Type: text/x-vcard, Size: 206 bytes --]

begin:vcard 
n:Squassoni;Daniela
x-mozilla-html:FALSE
org:Cyclades;R&D
adr:;;;;;;
version:2.1
email;internet:daniela@cyclades.com
title:Software Engineer
x-mozilla-cpt:;-3392
fn:Daniela Squassoni
end:vcard