2.5.1 - Cannot mount Hpfs partitions, cdroms, shutdown

2.5.1 - Cannot mount Hpfs partitions, cdroms, shutdown

[Carl Scarfoglio]

I have ext2/, Fat16, Hpfs, Ntfs and reiserfs partitions on several
disks on a SuSE 6.3 system.
With kernel 2.5.1 I cannot mount Hpfs partitions, the
others work. See attached boot.msg.

At shutdown the system stops at the message: Sending TERM signal to 
applications (or something of the like), just before unmounting. Power 
off solves the problem.

I still can't mount data cdroms, as in pre8-pre11, but the system does 
not lock-up and require a power cycle. The mount fails nicely with the 
generic error message "Wrong fs type, device already mounted, etc..."

Back to 2.5.0



 > <6>Adding Swap: 136512k swap-space (priority -1)
 > <6>Adding Swap: 128484k swap-space (priority -2)
 > <4>invalid operand: 0000
 > <4>CPU:    0
 > <4>EIP:    0010:[grow_buffers+80/256]    Not tainted
 > <4>EFLAGS: 00010286
 > <4>eax: fffffe00   ebx: 00000305   ecx: c035b5a0   edx: 00000200
 > <4>esi: 00000000   edi: 00000305   ebp: 00000000   esp: cfa9ddd8
 > <4>ds: 0018   es: 0018   ss: 0018
 > <4>Process mount (pid: 24, stackpage=cfa9d000)
 > <4>Stack: 00000305 00000000 00000000 00000000 000025a0 c0134257 
00000305 00000000
 > <4> 00000000 cfa9de70 c158dc00 cfe4a280 c0134448 00000305 00000000 
00000000
 > <4> 00000200 c016a48c 00000305 00000000 00000000 cfa3f000 c01734cd 
c158dc00
 > <4>Call Trace: [getblk+39/64] [bread+24/112] [hpfs_map_sector+28/64] 
[hpfs_read_super+349/1840] [insert_super+57/64]
 > <4> [get_sb_bdev+510/624] [do_kern_mount+171/320] 
[do_add_mount+33/208] [do_mount+338/368] [copy_mount_options+77/160] 
[sys_mount+132/208]
 > <4> [system_call+51/56]
 > <4>
 > <4>Code: 0f 0b b9 ff ff ff ff 89 fa 66 c1 ea 08 89 fb b7 00 8b 44 24
 > Kernel logging (ksyslog) stopped.
 > Kernel log daemon terminating.
 >

[FIX] Re: 2.5.1 - Cannot mount Hpfs partitions, cdroms, shutdown

[Alexander Viro]

	Please, apply.  That should fix the things for hpfs.  Cdroms
are a different story - apparently started earlier.

diff -urN C1/fs/hpfs/super.c C1-hpfs/fs/hpfs/super.c
--- C1/fs/hpfs/super.c	Thu Oct 25 03:02:26 2001
+++ C1-hpfs/fs/hpfs/super.c	Mon Dec 17 17:18:05 2001
@@ -410,6 +410,8 @@
 	/*s->s_hpfs_mounting = 1;*/
 	dev = s->s_dev;
 	set_blocksize(dev, 512);
+	s->s_blocksize = 512;
+	s->s_blocksize_bits = 9;
 	s->s_hpfs_fs_size = -1;
 	if (!(bootblock = hpfs_map_sector(s, 0, &bh0, 0))) goto bail1;
 	if (!(superblock = hpfs_map_sector(s, 16, &bh1, 1))) goto bail2;
@@ -436,8 +438,6 @@
 
 	/* Fill superblock stuff */
 	s->s_magic = HPFS_SUPER_MAGIC;
-	s->s_blocksize = 512;
-	s->s_blocksize_bits = 9;
 	s->s_op = &hpfs_sops;
 
 	s->s_hpfs_root = superblock->root;