public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Suardi <alessandro.suardi@oracle.com>
To: _PepeR_ <peper@wsisiz.edu.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.1 crashed during sending processes TERM signal
Date: Tue, 18 Dec 2001 14:06:05 +0100	[thread overview]
Message-ID: <3C1F3F3D.14B515F0@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.42.0112181226460.20596-100000@oceanic.wsisiz.edu.pl>

_PepeR_ wrote:
> 
> Hello,
> 
> At shutdown the system stops at the message "Sending all precesses TERM
> signal...". The isn't any messages of possible failure in logs.
> I'm using 2.5.1 kernel. If it's matter my system is an Athlon 1GHz on ECS
> K7S5A mainboard. If you need some detailed information please contact me
> on my e-mail 'coz I'm not subscribed to lkml.

No, this is generic, and is due to a recent patch (from -pre11 to -final)
 that should have made Linux more standards-compliant. Linus already
 reverted it in his tree so I assume the correctly-working shutdown
 sequence will work again in 2.5.2-preX. zdiff'ing -pre11 from -final
 patches I'd say it's this chunk (don't try to apply with 'patch', I
 just cut'n'pasted from my xterm):

> --- v2.5.0/linux/kernel/signal.c      Wed Nov 21 16:26:27 2001
> +++ linux/kernel/signal.c     Fri Dec 14 12:25:24 2001
> @@ -649,8 +649,10 @@
>  /*
>   * kill_something_info() interprets pid in interesting ways just like kill(2).
>   *
> - * POSIX specifies that kill(-1,sig) is unspecified, but what we have
> - * is probably wrong.  Should make it like BSD or SYSV.
> + * POSIX (2001) specifies "If pid is -1, sig shall be sent to all processes
> + * (excluding an unspecified set of system processes) for which the process
> + * has permission to send that signal."
> + * So, probably the process should also signal itself.
>   */
>  
>  static int kill_something_info(int sig, struct siginfo *info, int pid)
> @@ -663,7 +665,7 @@
>  
>               read_lock(&tasklist_lock);
>               for_each_task(p) {
> -                     if (p->pid > 1 && p != current) {
> +                     if (p->pid > 1) {
>                               int err = send_sig_info(sig, info, p);
>                               ++count;
>                               if (err != -EPERM)


I see the same behavior on RedHat 7.2.

--alessandro

 "we live as we dream alone / to break the spell we mix with the others
  we were not born in isolation / but sometimes it seems that way"
     (R.E.M., live intro to 'World Leader Pretend')

       reply	other threads:[~2001-12-18 13:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.42.0112181226460.20596-100000@oceanic.wsisiz.edu.pl>
2001-12-18 13:06 ` Alessandro Suardi [this message]
2001-12-18 15:04 ` 2.5.1 crashed during sending processes TERM signal Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C1F3F3D.14B515F0@oracle.com \
    --to=alessandro.suardi@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peper@wsisiz.edu.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox