From: Andrew Morton <akpm@zip.com.au>
To: Keith Owens <kaos@ocs.com.au>
Cc: Jason Thomas <jason@topic.com.au>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] link errors with internal calls to devexit functions
Date: Fri, 21 Dec 2001 21:26:16 -0800 [thread overview]
Message-ID: <3C241978.65020179@zip.com.au> (raw)
In-Reply-To: Your message of "Sat, 22 Dec 2001 13:57:25 +1100." <20011222025725.GA629@topic.com.au> <5750.1008997543@ocs3.intra.ocs.com.au>
Keith Owens wrote:
>
> __devexit_call(bttv_remove(dev));
> __devexit_call(uhci_pci_remove(dev));
This may break the drivers. They both call the remove
function on the init path, when something failed.
I believe the correct fix here is to simply remove __devinit altogether
from the definition of both those functions.
next prev parent reply other threads:[~2001-12-22 5:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-22 2:57 [PATCH] link errors with internal calls to devexit functions Jason Thomas
2001-12-22 5:05 ` Keith Owens
2001-12-22 5:26 ` Andrew Morton [this message]
2001-12-22 9:04 ` Kai Germaschewski
2001-12-22 9:13 ` Keith Owens
2001-12-25 17:59 ` Legacy Fishtank
2001-12-25 17:56 ` Legacy Fishtank
-- strict thread matches above, loose matches on Subject: below --
2002-01-09 4:40 Jason Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C241978.65020179@zip.com.au \
--to=akpm@zip.com.au \
--cc=jason@topic.com.au \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox