Re: lvm in 2.5.1

Andrew Morton
2001-12-27T19:49:56Z

andersg@0x63.nu wrote:
>
> On Thu, Dec 27, 2001 at 11:25:39AM -0800, Andrew Morton wrote:
> > 0xc02546c7 <lvm_do_vg_create+3>: sub $0x1d4,%esp
> >
> > So perhaps we have a compiler problem. Which version of the
> > compiler are you using? Have you verified that sizeof(lv_t)
> > is really around 420 bytes in your setup?
>
> gcc version 2.95.4 20011223 (Debian prerelease)
>
> i didn't check the exact amount. i dont know where the 420 bytes comes from?
> but (as Mike Galbraith pointed out) a lv_t contains:
>
> sector_t blocks[LVM_MAX_SECTORS];
>
> with:
>
> #define LVM_MAX_ATOMIC_IO 512
> #define LVM_MAX_SECTORS (LVM_MAX_ATOMIC_IO * 2)
>
> and
> typedef unsigned long sector_t;
>
> unsigned long beeing 4bytes => the blocks-member of lv_t should then be 4096
> by it self...

Ah. Right you are. I was looking at the 2.4.17 source. That array
was added in 2.5.x.

So 2.4.x is OK.

Thanks ;)

-