public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: andersg@0x63.nu
Cc: linux-kernel@vger.kernel.org, lvm-devel@sistina.com
Subject: Re: lvm in 2.5.1
Date: Thu, 27 Dec 2001 11:45:02 -0800	[thread overview]
Message-ID: <3C2B7A3E.E5C05404@zip.com.au> (raw)
In-Reply-To: <20011227084304.GA26255@h55p111.delphi.afb.lu.se> <3C2AEADB.24BEFE94@zip.com.au> <20011227122520.GA2194@h55p111.delphi.afb.lu.se> <3C2B75B3.4DEF90D3@zip.com.au>, <3C2B75B3.4DEF90D3@zip.com.au> <20011227193711.GB20501@h55p111.delphi.afb.lu.se>

andersg@0x63.nu wrote:
> 
> On Thu, Dec 27, 2001 at 11:25:39AM -0800, Andrew Morton wrote:
> > 0xc02546c7 <lvm_do_vg_create+3>:        sub    $0x1d4,%esp
> >
> > So perhaps we have a compiler problem.  Which version of the
> > compiler are you using?   Have you verified that sizeof(lv_t)
> > is really around 420 bytes in your setup?
> 
> gcc version 2.95.4 20011223 (Debian prerelease)
> 
> i didn't check the exact amount. i dont know where the 420 bytes comes from?
> but (as Mike Galbraith pointed out) a lv_t contains:
> 
>         sector_t blocks[LVM_MAX_SECTORS];
> 
> with:
> 
> #define LVM_MAX_ATOMIC_IO       512
> #define LVM_MAX_SECTORS         (LVM_MAX_ATOMIC_IO * 2)
> 
> and
> typedef unsigned long sector_t;
> 
> unsigned long beeing 4bytes => the blocks-member of lv_t should then be 4096
> by it self...

Ah.  Right you are.  I was looking at the 2.4.17 source.  That array
was added in 2.5.x.

So 2.4.x is OK.

Thanks ;)

-

  reply	other threads:[~2001-12-27 19:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-27  8:43 lvm in 2.5.1 andersg
2001-12-27  9:33 ` Andrew Morton
2001-12-27 12:25   ` andersg
2001-12-27 13:54     ` andersg
2001-12-27 15:20       ` Jens Axboe
2001-12-27 16:02         ` andersg
2001-12-27 16:11           ` Jens Axboe
2001-12-27 17:18           ` [lvm-devel] " Andreas Dilger
2001-12-27 19:25     ` Andrew Morton
2001-12-27 19:37       ` andersg
2001-12-27 19:45         ` Andrew Morton [this message]
2001-12-27 20:24           ` andersg
2001-12-28 16:45             ` Jan Niehusmann
2001-12-28 20:17               ` [lvm-devel] " Andreas Dilger
2001-12-28 20:43                 ` andersg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C2B7A3E.E5C05404@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=andersg@0x63.nu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvm-devel@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox