[PATCH] sis drm module

[PATCH] sis drm module

[Thomas Winischhofer]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]


Hi,

without this patch, only root can execute DRI applications under X.
Users can't and just receive a (incorrect) "out of video memory" error,
which is basically a "permission denied".

Please apply.

Thomas

-- 
Thomas Winischhofer
Vienna/Austria
mailto:tw@webit.com              *** http://www.webit.com/tw

[-- Attachment #2: sis_patch --]
[-- Type: text/plain, Size: 722 bytes --]

--- /usr/src/linux/drivers/char/drm/sis_drv_old.c	Thu Dec 27 23:52:11 2001
+++ /usr/src/linux/drivers/char/drm/sis_drv.c	Thu Dec 27 23:45:48 2001
@@ -40,8 +40,8 @@
 #define DRIVER_PATCHLEVEL  0
 
 #define DRIVER_IOCTLS \
-        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,	  1, 1 }, \
-        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,	  1, 1 }, \
+        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,	  1, 0 }, \
+        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,	  1, 0 }, \
         /* AGP Memory Management */					  \
         [DRM_IOCTL_NR(SIS_IOCTL_AGP_INIT)]   = { sisp_agp_init,	  1, 1 }, \
         [DRM_IOCTL_NR(SIS_IOCTL_AGP_ALLOC)]  = { sisp_agp_alloc,  1, 1 }, \

Re: [PATCH] sis drm module

[Jason Lott]

At 12:11 AM 12/28/01 +0100, you wrote:

>Hi,
>
>without this patch, only root can execute DRI applications under X.
>Users can't and just receive a (incorrect) "out of video memory" error,
>which is basically a "permission denied".
>
>Please apply.
>
>Thomas


Definitely gets my vote... The patch also resolves a hard xfree86-4.1.0 
build error
of sis_alloc.c Thank you Thomas, you've helped to make my life a little bit 
easier!
Please, Apply the patch

Jason Lott

>--
>Thomas Winischhofer
>Vienna/Austria
>mailto:tw@webit.com              *** http://www.webit.com/tw--- 
>/usr/src/linux/drivers/char/drm/sis_drv_old.c   Thu Dec 27 23:52:11 2001
>+++ /usr/src/linux/drivers/char/drm/sis_drv.c   Thu Dec 27 23:45:48 2001
>@@ -40,8 +40,8 @@
>  #define DRIVER_PATCHLEVEL  0
>
>  #define DRIVER_IOCTLS \
>-        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,   1, 1 }, \
>-        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,    1, 1 }, \
>+        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,   1, 0 }, \
>+        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,    1, 0 }, \
>          /* AGP Memory Management */                                      \
>          [DRM_IOCTL_NR(SIS_IOCTL_AGP_INIT)]   = { 
> sisp_agp_init,          1, 1 }, \
>          [DRM_IOCTL_NR(SIS_IOCTL_AGP_ALLOC)]  = { sisp_agp_alloc,  1, 1 }, \