Re: Sound fails to build when non-modular with new binutils

Andrew Morton
2001-12-28T18:32:24Z

André Dahlqvist wrote:
>
> Keith Owens <kaos@ocs.com.au> wrote:
>
> > Run this, it will say precisely where the problem lies:
>
> Thanks Keith. Below is the output:
>
> Finding objects, 315 objects, ignoring 0 module(s)
> Finding conglomerates, ignoring 29 conglomerate(s)
> Scanning objects
> Error: ./drivers/sound/via82cxxx_audio.o .data refers to 00000034
> R_386_32 .text.exit
> Done

Could you please check that this works OK?

--- linux-2.4.18-pre1/drivers/sound/via82cxxx_audio.c Fri Dec 21 11:19:13 2001
+++ linux-akpm/drivers/sound/via82cxxx_audio.c Fri Dec 28 10:27:51 2001
@@ -365,7 +365,7 @@ static struct pci_driver via_driver = {
name: VIA_MODULE_NAME,
id_table: via_pci_tbl,
probe: via_init_one,
- remove: via_remove_one,
+ remove: __devexit_p(via_remove_one),
};

@@ -3271,7 +3271,7 @@ err_out:
}

-static void __exit via_remove_one (struct pci_dev *pdev)
+static void __devexit via_remove_one (struct pci_dev *pdev)
{
struct via_info *card;