public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Oliver Xymoron <oxymoron@waste.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC, CFT] include file cleanup
Date: Sat, 29 Dec 2001 23:19:04 +0100	[thread overview]
Message-ID: <3C2E4158.93ACFFA3@colorfullife.com> (raw)
In-Reply-To: <Pine.LNX.4.43.0112291552080.18183-100000@waste.org>

Oliver Xymoron wrote:
> 
> 
> Maybe. You might want to pull the rest of the get_free_page functions
> out with it.

Yes, I overlooked them. Thanks.

> 
> > Another similar cleanup would be  splitting the 'struct task_struct'
> > definition out of sched.h into a seperate <linux/current.h>:
> > some source files only include sched.h because they dereference
> > one field within current.
> 
> Tried it yet? I think you'll find this very difficult because of all the
> things task_struct references.
>
It wasn't that difficult: only these includes are needed to pull in all
substructures ;-)

<<<<<<<
#include <linux/config.h>
#include <linux/types.h>
#include <linux/spinlock.h>
#include <linux/list.h>
#include <linux/wait.h>
#include <linux/timer.h>
#include <linux/times.h>
#include <linux/capability.h>
#include <linux/resource.h>
#include <linux/signal.h>
#include <asm/param.h>
#include <asm/signal.h>
#include <asm/processor.h>
#include <asm/resource.h>
<<<<<<<<<

Another target is IS_ERR: several header files include fs.h because they
need it.
--
	Manfred

  reply	other threads:[~2001-12-29 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-29 18:23 [RFC, CFT] include file cleanup Manfred Spraul
2001-12-29 19:31 ` Benjamin LaHaise
2001-12-29 21:58 ` Oliver Xymoron
2001-12-29 22:19   ` Manfred Spraul [this message]
2001-12-29 22:28     ` Oliver Xymoron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C2E4158.93ACFFA3@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oxymoron@waste.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox