public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Albert Cranford <ac9410@bellsouth.net>
Cc: ollie@sis.com.tw, linux-kernel@vger.kernel.org,
	Keith Owens <kaos@ocs.com.au>,
	Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [PATCH]take2 2.4.18-pre1 sound/trident fix with newer binutils
Date: Wed, 02 Jan 2002 14:36:13 -0500	[thread overview]
Message-ID: <3C33612D.7BAC53EC@mandrakesoft.com> (raw)
In-Reply-To: <3C3313E4.10B5E0D2@bellsouth.net>

Albert Cranford wrote:
> -static void __exit trident_cleanup_module (void)
> +static void __devexit trident_cleanup_module (void)
>  {
>         pci_unregister_driver(&trident_pci_driver);
>  }

cleanup_module (module_exit) never ever has a reason to be __devexit. 
It is run once at module exit, regardless of CONFIG_HOTPLUG.  If !MODULE
the function is dropped, that's the only requirement.

-- 
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno

      reply	other threads:[~2002-01-02 19:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-02 14:06 [PATCH]take2 2.4.18-pre1 sound/trident fix with newer binutils Albert Cranford
2002-01-02 19:36 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C33612D.7BAC53EC@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=ac9410@bellsouth.net \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=ollie@sis.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox