From: Andrew Morton <akpm@zip.com.au>
To: Oliver Xymoron <oxymoron@waste.org>
Cc: vda <vda@port.imtp.ilyichevsk.odessa.ua>, linux-kernel@vger.kernel.org
Subject: Re: Extern variables in *.c files
Date: Wed, 02 Jan 2002 13:43:13 -0800 [thread overview]
Message-ID: <3C337EF1.4C7C72AB@zip.com.au> (raw)
In-Reply-To: <02010216180403.01928@manta> <Pine.LNX.4.43.0201021322120.30079-100000@waste.org>
Oliver Xymoron wrote:
>
> On Wed, 2 Jan 2002, vda wrote:
>
> > I grepped kernel *.c (not *.h!) files for extern variable definitions.
> > Much to my surprize, I found ~1500 such defs.
> >
> > Isn't that bad C code style? What will happen if/when type of variable gets
> > changed? (int->long).
>
> Yes; Int->long won't change anything on 32-bit machines and will break
> silently on 64-bit ones. The trick is finding appropriate places to put
> such definitions so that all the things that need them can include them
> without circular dependencies.
>
Isn't there some way to get the linker to detect the differing
sizes?
-
next prev parent reply other threads:[~2002-01-02 21:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-02 18:18 Extern variables in *.c files vda
2002-01-02 19:24 ` Oliver Xymoron
2002-01-02 21:43 ` Andrew Morton [this message]
2002-01-02 22:07 ` Momchil Velikov
2002-01-03 7:19 ` Andrew Morton
2002-01-03 7:42 ` H . J . Lu
2002-01-03 7:56 ` Andrew Morton
2002-01-03 8:24 ` Keith Owens
2002-01-03 9:57 ` Russell King
2002-01-04 0:28 ` Extern variables in *.c files (maintainers pls read this) vda
2002-01-03 23:14 ` Olaf Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C337EF1.4C7C72AB@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=oxymoron@waste.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox