From: Douglas Gilbert <dougg@torque.net>
To: Peter Osterlund <petero2@telia.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] kernel BUG at scsi_merge.c:83
Date: Wed, 02 Jan 2002 23:28:29 -0500 [thread overview]
Message-ID: <3C33DDED.7212F2F9@torque.net> (raw)
Peter Osterlund <petero2@telia.com> wrote:
> Jens Axboe <axboe@suse.de> writes:
>
> > On Wed, Jan 02 2002, Peter Osterlund wrote:
> > > Hi!
> > >
> > > While doing some stress testing on the 2.5.2-pre5 kernel, I am hitting
> > > a kernel BUG at scsi_merge.c:83, followed by a kernel panic. The
> > > problem is that scsi_alloc_sgtable fails because the request contains
> > > too many physical segments. I think this patch is the correct fix:
> >
> > Correct, ll_rw_blk default is ok now. I missed this when killing
> > scsi_malloc/scsi_dma, thanks.
>
> It turns out this is still not enough to fix the problem for me,
> because ll_new_hw_segment is still allowing nr_phys_segments to become
> too large. Is the following patch the correct way to deal with this
> problem, or is that case supposed to be prevented by some other means?
> At least, this patch prevents the kernel panic during my stress test.
<snipped patches/>
Peter,
I was able to get a repeatable oops at that line copying
files from /boot onto a "fake" scsi_debug disk with "pre5".
The first largish file it attempted to copy caused the
oops (which I sent to Jens).
Anyway, I just applied your 2 patches (to scsi.c and ll_rw_blk.c)
and the oops is no more.
Good work.
Doug Gilbert
next reply other threads:[~2002-01-03 4:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-03 4:28 Douglas Gilbert [this message]
2002-01-03 8:18 ` [PATCH] kernel BUG at scsi_merge.c:83 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2002-01-02 1:38 Peter Osterlund
2002-01-02 7:32 ` Jens Axboe
2002-01-02 11:23 ` Peter Osterlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C33DDED.7212F2F9@torque.net \
--to=dougg@torque.net \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox