public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steffen Persvold <sp@scali.no>
To: lkml <linux-kernel@vger.kernel.org>
Subject: Short question about the mmap method
Date: Fri, 04 Jan 2002 21:25:57 +0100	[thread overview]
Message-ID: <3C360FD5.91285F5D@scali.no> (raw)

Hi lkml readers,

I have a question regarding drivers implementing the mmap and nopage methods. In some references
I've read that pages in kernel allocated memory (either allocated with kmalloc, vmalloc or
__get_free_pages) should be set to reserved (mem_map_reserve or set_bit(PG_reserved, page->flags)
before they can be mmap'ed to guarantee that they can't be swapped out. Is this true ?

The reason I ask is that I have a test driver that allocates some pages with vmalloc(), reserves
them with mem_map_reserve(), and uses the "nopage" method to give a userspace app access to them.
When the userpace app accesses the page, the "nopage" function is invoked as expected and the
page->count is incremented (by the nopage function). When this application exits the page->count
should have been decremented by the kernel, but it seems like it doesn't since the page is reserved
and this causes a giant memleak when the driver is unloaded since the pages are not put back to the
free list unless page->count is zero (I do mem_map_unreserve before vfree). If I avoid using
mem_map_reserve (and _unreserve) the page count is 1 at the time I unload the driver and everything
goes fine.

The kernel I'm using is RedHat 7.2 2.4.9-12

One more question:

When getting the "struct page" for pages allocated with vmalloc() I use the same method as
drivers/media/video/bttv-driver.c (checking the page table). Somewhere (I think Rubini) I read that
the init_mm.page_table_lock should be held before checking the page table. Is this true, or can it
safely be done without doing that (the bttv-driver.c doesn't) ?

Any ideas & comments are appreciated.

Thanks,
-- 
  Steffen Persvold   | Scalable Linux Systems |   Try out the world's best   
 mailto:sp@scali.no  |  http://www.scali.com  | performing MPI implementation:
Tel: (+47) 2262 8950 |   Olaf Helsets vei 6   |      - ScaMPI 1.12.2 -         
Fax: (+47) 2262 8951 |   N0621 Oslo, NORWAY   | >300MBytes/s and <4uS latency

             reply	other threads:[~2002-01-04 20:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-04 20:25 Steffen Persvold [this message]
2002-01-04 20:59 ` Short question about the mmap method Tommy Reynolds
2002-01-05  1:07   ` Steffen Persvold
2002-01-05  2:56     ` Steffen Persvold
2002-01-05  3:59       ` Steffen Persvold
2002-01-05 14:17 ` Roman Zippel
  -- strict thread matches above, loose matches on Subject: below --
2002-01-05 17:52 Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C360FD5.91285F5D@scali.no \
    --to=sp@scali.no \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox