Re: [PATCH] DevFS support for /dev/cpu/X/(cpuid|msr)

Richard Gooch
2002-02-18T18:38:45Z

Ishan Jayawardena writes:
> This is a multi-part message in MIME format.

First comment: please send the patch inline, not MIME-encoded.

> I'd love to extend this work to support Paul Russell's hotplug cpu work, but
> I have absolutely no way at present to test it. (If some kind party would
> like to donate a quad pentium 4 Xeon with hotplug cpu support, I'll be more
> than happy to do so ;)
>
> This is against 2.4.18-pre9-ac4 with devfs v199.9
>
> Relevent comments, advise, improvisations, flames, welcome.

Second comment: devfs_(un)register_per_cpu() doesn't belong in
fs/devfs/base.c. I don't even think it should be in fs/devfs/util.c.
I think it belongs kernel/smp.c (that's right, create a new file).
There's too much duplicated SMP code in each arch/ tree. Let's create
a place for new stuff to be shared.

So, please send along your next version of the patch (inlined, of
course:-).

Regards,

Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca