From: "Peter Wächtler" <pwaechtler@loewe-komp.de>
To: Denis RICHARD <Denis.Richard@sxb.bsf.alcatel.fr>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: e2compress on Linux 2.4.16
Date: Mon, 07 Jan 2002 11:14:10 +0100 [thread overview]
Message-ID: <3C3974F2.3AEE6768@loewe-komp.de> (raw)
In-Reply-To: <3C33906D.5799612A@loewe-komp.de> <3C364A68.D586144E@loewe-komp.de>
Peter Wächtler schrieb:
>
> > Bonjour,
> >
> > I tried your e2compress patches and it didn't work for me at the
> > first run :-( After compression of some larger files (>400KiB)
> > the files couldn't be stat()ed -> the i_blocks field was "negative".
> >
> > in fs/ext2/cpmpress.c::ext2_compress_cluster:2886
> > inode->i_blocks -= ((u_nblk - c_nblk)
> > << (inode->i_sb->s_blocksize_bits - 9));
> >
> > has to be deleted. Otherwise the i_blocks field gets decremented
> > twice. Depending on the glibc version you use, a stat() fails
> > due to some conversion code between lstat64() and userspace
> > returning EOVERFLOW and "negative i_blocks" (viewable with debugfs)
> >
> > ext2_free_blocks() calls DQUOT_FREE_BLOCK() which calls
> > include/linux/fs.h::inode_sub_bytes() regardless if CONFIG_QUOTA
> > is enabled or not.
> > In 2.2 the quota code was different - so there it was correct
> > to substract the free'ed blocks.
> >
> > With this "fix" all seems to work fine. So thanx for your work!
> >
Since I didn't get any reply so far (perhaps you have longer vacation than me:)
I resend my mail and also cc:lkml - take it as a positive feedback!
parent reply other threads:[~2002-01-07 10:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <3C364A68.D586144E@loewe-komp.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3974F2.3AEE6768@loewe-komp.de \
--to=pwaechtler@loewe-komp.de \
--cc=Denis.Richard@sxb.bsf.alcatel.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox