Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)

Jeff Garzik
2002-01-07T23:46:37Z

Daniel Phillips wrote:
>
> On January 7, 2002 04:19 pm, Daniel Phillips wrote:
> > - You are dreferencing a pointer, and have two allocations for every
> > inode instead of one.
>
> Oh no, you only have one allocator, and you have the filesystem do it, with
> per-sb methods. Why is this better than having the VFS do it? Does this
> imply you might have different sized inodes with different mounts of the same
> filesystem?
>
> The per-fs cost with my variant is: 4-8 bytes per filesystem, period. No
> methods needed, and the object management code doesn't get replicated through
> all the filesystems.

I greatly prefer function pointers to [possibly] generic obj management
code, to storing object sizes. Some filesystem is inevitably going to
want to do something even more clever with inode allocation. My method
gives developers the freedom to experiement with inode alloc to their
heart's desires, without affecting any other filesystem.

> Also, having the inode point at itself is a little, hmm, 'what's wrong with
> this picture', don't you think?

gone in the updated patch :)

--
Jeff Garzik | Alternate titles for LOTR:
Building 1024 | Fast Times at Uruk-Hai
MandrakeSoft | The Took, the Elf, His Daughter and Her Lover
| Samwise Gamgee: International Hobbit of Mystery