Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)

Andreas Dilger
2002-01-08T00:16:19Z

On Jan 07, 2002 18:48 -0500, Jeff Garzik wrote:
> Daniel Phillips wrote:
> > Moving the ext2 headers from include/linux to fs/ext2 is an interesting
> > feature of your patch, though it isn't essential to the idea you're
> > presenting. But is there a good reason why ext2_fs_i.h and ext2_fs_sb.h
> > should remain separate from ext2_fs.h? It looks like gratuitous
> > modularity to me.
>
> apparently userspace includes them, which is the reason for the strange
> types. good reason to continue to keep them separate. That's also why
> my patch7 adds an ifdef __KERNEL__.

Could you be more specific? AFAIK, the ext2_fs.h file is also used by
e2fsprogs (which actually has its own, _more_ up-to-date version of this
file), but the _i.h and _sb.h files are for kernel use only. They do not
have any relation to on-disk ext2 structs, so there would not really be
any point in referencing them from userspace.

Cheers, Andreas
--
Andreas Dilger