Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)

Daniel Phillips
2002-01-08T04:08:16Z

On January 7, 2002 09:54 pm, Juan Quintela wrote:
> >>>>> "daniel" == Daniel Phillips <phillips@bonn-fries.net> writes:
>
> Hi
>
> daniel> Minor nit:
>
> daniel> if (!inode->u.ext2_ip)
> daniel> BUG();
>
> daniel> You don't have to do this, if the pointer is null you will get a perfectly
daniel> fine oops.
>
> Without nice line information :(
>
> Later, Juan.

Well that's a problem with the oopser, don't you think? It's not right to put in
cpu-eating BUG checks for null pointer dereference all over the place just to work
around this deficiency.

--
Daniel