public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Bryant <nbryant@allegientsystems.com>
To: Mario Mikocevic <mozgy@hinet.hr>
Cc: Doug Ledford <dledford@redhat.com>,
	Thomas Gschwind <tom@infosys.tuwien.ac.at>,
	linux-kernel@vger.kernel.org
Subject: Re: i810_audio
Date: Tue, 08 Jan 2002 14:22:27 -0500	[thread overview]
Message-ID: <3C3B46F3.5010107@allegientsystems.com> (raw)
In-Reply-To: <20020105031329.B6158@infosys.tuwien.ac.at> <3C3A2B5D.8070707@allegientsystems.com> <3C3A301A.2050501@redhat.com> <3C3AA6F9.5090407@redhat.com> <3C3AA9AD.6070203@redhat.com> <3C3AB5AB.2080102@redhat.com> <20020108161137.A6747@danielle.hinet.hr>

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

Mario Mikocevic wrote:

>Hi,
>
>>OK, various clean ups made, and enough of the SiS code included that I think 
>>it should work, plus one change to the i810 interrupt handler that will 
>>(hopefully) render the other change you made to get_dma_addr and drain_dac 
>>unnecessary.  If people could please download and test the new 0.14 version 
>>of the driver on my site, I would appreciate it.
>>
>>http://people.redhat.com/dledford/i810_audio.c.gz
>>
>
>Hmmm, maybe way too much cleanups !? :)
>
Works fine for me with the attached patch. (artsd, mmap mode ok so far)

[-- Attachment #2: 14.diff --]
[-- Type: text/plain, Size: 626 bytes --]

--- i810_audio.c.14	Tue Jan  8 03:28:31 2002
+++ linux/drivers/sound/i810_audio.c	Tue Jan  8 14:01:26 2002
@@ -655,7 +655,6 @@
 {
 	struct dmabuf *dmabuf = &state->dmabuf;
 	unsigned int civ, offset, port, port_picb, bytes = 2;
-	struct i810_channel *c;
 	
 	if (!dmabuf->enable)
 		return 0;
@@ -744,7 +743,7 @@
 	if(card->pci_id == PCI_DEVICE_ID_SI_7012)
 		outb( inb(card->iobase + PO_PICB), card->iobase + PO_PICB );
 	else
-		outb( inb(card->iobase + PO_SR), card->iobase + PI_OR );
+		outb( inb(card->iobase + PO_SR), card->iobase + PO_SR );
 	outl( inl(card->iobase + GLOB_STA) & INT_PO, card->iobase + GLOB_STA);
 }
 

  parent reply	other threads:[~2002-01-08 19:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3C338217.1080207@allegientsystems.com>
2002-01-05  2:13 ` i810_audio Thomas Gschwind
2002-01-07 19:32   ` i810_audio Nathan Bryant
2002-01-07 23:12   ` i810_audio Nathan Bryant
2002-01-07 23:32     ` i810_audio Doug Ledford
2002-01-08  7:59       ` i810_audio Doug Ledford
2002-01-08  8:11         ` i810_audio Doug Ledford
2002-01-08  9:02           ` i810_audio Doug Ledford
2002-01-08 15:11             ` i810_audio Mario Mikocevic
2002-01-08 19:21               ` i810_audio Doug Ledford
2002-01-08 19:22               ` Nathan Bryant [this message]
2002-01-09 15:47             ` i810_audio Mario Mikocevic
2002-01-08 20:01         ` i810_audio Nathan Bryant
2002-01-08 20:15           ` i810_audio Doug Ledford
2002-01-08 20:23           ` i810_audio Nathan Bryant
2002-01-08  8:22   ` i810_audio Martin Dalecki
2002-01-08 16:31 i810_audio willy tarreau
2002-01-08 19:58 ` i810_audio Doug Ledford
2002-01-08 23:03   ` i810_audio willy tarreau
2002-01-09  6:28   ` i810_audio Nick Papadonis
2002-01-09  7:16   ` i810_audio willy tarreau
  -- strict thread matches above, loose matches on Subject: below --
2002-01-09  7:09 i810_audio reddog83
     [not found] <3C3BFF98.9080309@redhat.com>
2002-01-09  9:08 ` i810_audio willy tarreau
2002-01-10  6:42 i810_audio reddog83
2002-01-10 18:59 i810_audio reddog83
2002-01-10 19:21 i810_audio reddog83
2002-01-11  0:33 ` i810_audio Doug Ledford
2002-11-10 23:37 i810 audio Alan Cox
2002-11-12 23:06 ` Brian C. Huffman
2002-11-12 23:38   ` Alan Cox
2002-11-12 23:43     ` Doug Ledford
2002-11-13  0:04       ` Peter Kundrat
2002-11-13  0:43         ` Alan Cox
2002-11-13 12:08           ` Brian C. Huffman
2002-11-12 23:52     ` Peter Kundrat
2002-11-11 21:16 i810_audio Rus Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3B46F3.5010107@allegientsystems.com \
    --to=nbryant@allegientsystems.com \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mozgy@hinet.hr \
    --cc=tom@infosys.tuwien.ac.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox