From: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, Nick Craig-Wood <ncw@axis.demon.co.uk>
Subject: Re: __FUNCTION__ - patch for USB
Date: Thu, 10 Jan 2002 12:52:57 +0200 [thread overview]
Message-ID: <3C3D7289.9000302@intel.com> (raw)
In-Reply-To: <3C3CC04D.2080807@intel.com> <20020109222657.GA23143@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
Greg KH wrote:
>
>Your patch makes whitespace changes to a lot of dbg() statements, but
>does not modify their contents. Can you please change this, as this
>change does not need to happen.
>
Yes, I realized it, but unfortunately too late. It's hard to revise all
patch chunk by chunk and undo changes when content not changed.
>>Patch is against 2.4.17
>>
>
>2.4.18-pre2 has a _lot_ of usb changes and this patch misses a number of
>places.
>
>I'd also like to see this against the 2.5.x tree first, as the
>recommended compiler for the 2.4.x tree is still 2.95.3, and I don't
>think that will change anytime soon.
>
>thanks,
>
>greg k-h
>
Patch against 2.4.18-pre2 attached. For 2.5 tree - wait a bit, I have to
return for a moment to business I get salary for.
Nick Craig-Wood wrote:
>
>I was going to suggest you use the C99 __func__ rather than
>__FUNCTION__ but after a quick test it doesn't seem to be supported by
>egcs-2.91.66 so I guess that is out for the time being? It is
>supported by gcc-2.95 though.
>
I considered it too. Unfortunately, __func__ is not supported by all gcc
versions, so __FUNCTION__ seems to be best solution so far. Also, I
aggregated all changes to one place in macro definition, it should be
easier to change, should this need arise.
>
[-- Attachment #2: __FUNCTION__.usb.patch.gz --]
[-- Type: application/x-gzip, Size: 41740 bytes --]
next prev parent reply other threads:[~2002-01-10 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 22:12 __FUNCTION__ - patch for USB Vladimir Kondratiev
2002-01-09 22:26 ` Greg KH
2002-01-10 10:52 ` Vladimir Kondratiev [this message]
2002-01-10 16:09 ` Greg KH
2002-01-11 12:23 ` Vladimir Kondratiev
2002-01-10 9:08 ` Nick Craig-Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3D7289.9000302@intel.com \
--to=vladimir.kondratiev@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncw@axis.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox