Re: [PATCH] Additions to full lowlatency patch

Jussi Laako
2002-01-12T22:40:37Z

arjan@fenrus.demon.nl wrote:
>
> Did you audit all uses of this function ? It sort of looks like you're
> doing "hey there's a udelay lets add a schedule".. ok that's a bit rude
> but I'm not totally convinced that this function isn't called with
> spinlocks helt...

I have not done deeper research on the codepaths, but I have tested the
drivers after change and they work. I tried to look for for/while {
usleep(n); } timeout waits and no dangerous looking spinlocks held or
interrupts disabled.

I'm ready to do more extensive work to fix similar cases if I get
theoretical "OK" for the changes. I won't continue if people point out that
this is wrong way(tm).

The patch is quick hack for my own use and for review and shouldn't be used
unless proven correct. It's just my first try to hack linux kernel... :)

I just dislike

while (!hardware_completed()) usleep(1000);

-style code in some drivers (a bit extreme example).