* acquire_console_sem exported, but not release_console_sem?
@ 2002-01-13 2:54 Michael C. Toren
2002-01-13 3:36 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Michael C. Toren @ 2002-01-13 2:54 UTC (permalink / raw)
To: linux-kernel
Hi,
In kernel/printk.c, it looks like acquire_console_sem() is exported, but
not release_console_sem()? Is this intentional, or just an oversight?
Thanks,
-mct
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: acquire_console_sem exported, but not release_console_sem?
2002-01-13 2:54 acquire_console_sem exported, but not release_console_sem? Michael C. Toren
@ 2002-01-13 3:36 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2002-01-13 3:36 UTC (permalink / raw)
To: Michael C. Toren; +Cc: linux-kernel, Marcelo Tosatti
"Michael C. Toren" wrote:
>
> Hi,
>
> In kernel/printk.c, it looks like acquire_console_sem() is exported, but
> not release_console_sem()? Is this intentional, or just an oversight?
Oversight. It's possible that some modular video drivers will need
to acquire this lock, so it should be exported. At this time, it's
only fbcon.c and that code doesn't support modular linkage, so
nobody has noticed.
--- linux-2.4.18-pre3/kernel/printk.c Thu Jan 10 13:39:50 2002
+++ linux-akpm/kernel/printk.c Sat Jan 12 19:32:50 2002
@@ -529,6 +529,7 @@ void release_console_sem(void)
if (must_wake_klogd && !oops_in_progress)
wake_up_interruptible(&log_wait);
}
+EXPORT_SYMBOL(release_console_sem);
/** console_conditional_schedule - yield the CPU if required
*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-01-13 3:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-13 2:54 acquire_console_sem exported, but not release_console_sem? Michael C. Toren
2002-01-13 3:36 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox