Re: [CFT][PATCH] watchdog nowayout and timeout module parameters

Padraig Brady
2002-01-15T12:28:41Z

Matt_Domsch@Dell.com wrote:

>>Timeout has been moved to an ioctl more by other diffs so Im not sure
>>timeout= is too important
>>
>
> Of the seven drivers I added this parm to, six do not offer such a method
> via ioctl:
> eurotechwdt.c provides WDIOC_SETTIMEOUT.

And was the first to provide it:
http://marc.theaimsgroup.com/?l=linux-kernel&m=100619600900700&w=2

> acquirewdt.c, advantechwdt.c, ib700wdt.c, pcwd.c, wdt.c, wdt_pci.c do not
> provide a set timeout ioctl.

I think all should? As it would be nice/more consistent for all

>
> These already offer a timeout parm, but no set timeout ioctl:
> i810-tco.c, softdog.c, wdt285.o
>
> The other drivers I didn't add timeout parm to anyhow, but they don't have a
> set timeout ioctl either:
> machzwd.c, mixcomwd.c, shwdt.c, wdt977.c

new version of wdt977 in patch does provide WDIOC_SETTIMEOUT

>
> Unless there are strong objections or a push to make it an ioctl everywhere
> instead/also, I'd like to leave it in.

Personally I'm undecided whether param or ioctl is preferable.

I don't think many would need to change the timeout parameter
at runtime, but if you do it's a pain to reload the module,
so I vote for providing both interfaces?

>
>>Rest looks good
>>
>
> Thanks for reviewing and approving. 14 drivers modified, 5 drivers
> approved, one investigating, two email addresses invalid, leaving 6 to hear
> from.
>
> -Matt

What about the following though?

cpwatchdog.c
riowatchdog.c
sbc60xxwdt.c

Actually I think there should be a drivers/char/watchdog directory ?
(there are now around 18 seperate watchdog drivers).
Then the out of date watchdog.txt could be updated to point users
at this directory to see what's available, rather than the current
out of date list:

ICS WDT501-P
ICS WDT501-P (no fan tachometer)
ICS WDT500-P
Software Only
SA1100 Internal Watchdog
Berkshire Products PC Watchdog Revision A & C (by Ken Hollis)

ALso I've drivers here for {IBASE, Portwell} SBC watchdogs.
[Who] will I submit them to?

cheers,
Padraig.