From: Douglas Gilbert <dougg@torque.net>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@suse.de>
Subject: [PATCH] sg in lk 2.5.3-pre5
Date: Sat, 26 Jan 2002 21:21:50 -0500 [thread overview]
Message-ID: <3C53643E.47EDB3C2@torque.net> (raw)
In pre5 the sg driver tries to set up both address
and page+offset in scatterlist entries. Unfortunately
asm-i386/pci.h's pci_map_sg() contains this check:
if (sg[i].address && sg[i].page)
BUG();
which kills that strategy with the sym53c8xx driver.
The sooner we get rid of address in struct scatterlist
the better ... the address,page+offset duality is a mess.
Strange that Andi Kleen had problems compiling ide-scsi,
it compiled and worked on my UP and SMP machines (AMD and
dual Celeron respectively).
Sg patch (which has been already sent to Jens) follows.
Doug Gilbert
--- linux/drivers/scsi/sg.c Thu Jan 24 18:45:01 2002
+++ linux/drivers/scsi/sg.c3523 Thu Jan 24 20:53:28 2002
@@ -19,7 +19,7 @@
*/
#include <linux/config.h>
#ifdef CONFIG_PROC_FS
- static char sg_version_str[] = "Version: 3.5.23 (20020103)";
+ static char sg_version_str[] = "Version: 3.5.23 (20020124)";
#endif
static int sg_version_num = 30523; /* 2 digits for each component */
/*
@@ -76,7 +76,7 @@
#include <linux/version.h>
#endif /* LINUX_VERSION_CODE */
-#define SG_STILL_HAVE_ADDRESS_IN_SCATTERLIST
+/* #define SG_STILL_HAVE_ADDRESS_IN_SCATTERLIST */
#define SG_ALLOW_DIO_DEF 0
#define SG_ALLOW_DIO_CODE /* compile out be commenting this define */
next reply other threads:[~2002-01-27 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-27 2:21 Douglas Gilbert [this message]
2002-01-27 2:44 ` [PATCH] sg in lk 2.5.3-pre5 Andi Kleen
2002-01-27 10:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C53643E.47EDB3C2@torque.net \
--to=dougg@torque.net \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox