public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: "Kevin P. Fleming" <kevin@labsysgrp.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [CFT] Bus mastering support for IDE CDROM audio
Date: Sat, 26 Jan 2002 19:16:43 -0800	[thread overview]
Message-ID: <3C53711B.F8D89811@zip.com.au> (raw)
In-Reply-To: <3C5119E0.6E5C45B6@zip.com.au> <000701c1a5d5$812ef580$6caaa8c0@kevin>

"Kevin P. Fleming" wrote:
> 
> When reading from the N drive, get lots of "cdrom_pc_intr: read too
> little data 0 < 2352",

OK, thanks Kevin (Dan, Kristian, Grant..)

Seems that some devices simply terminate their DMA in a normal
manner, report no errors and don't tell us how much data they
transferred.  From my reading of the ATA spec, they're allowed
to do that - they only need to report the transfer byte count
in PIO mode.

Could you please change the code in drivers/ide/ide-cd.c:cdrom_pc_intr() to:

                if ((stat & DRQ_STAT) == 0 && len < pc->buflen) {
                        printk(__FUNCTION__ ": read too little data! %d < %d\n",
                                        len, pc->buflen);
+                       len = pc->buflen;
                }
                pc->buflen -= len;
                pc->buffer += len;

and let me know if the thing actually reads audio correctly?

Also, please tell me whether that particular drive reads normal
ISO filesystems correctly in DMA mode?   Thanks.

-

  parent reply	other threads:[~2002-01-27  3:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-25  8:40 [CFT] Bus mastering support for IDE CDROM audio Andrew Morton
2002-01-25 19:21 ` Kevin P. Fleming
2002-01-27  2:13   ` Dan Chen
2002-01-27  3:16   ` Andrew Morton [this message]
2002-01-27  6:41     ` Andrew Morton
2002-01-27  9:11       ` Kristian
2002-01-27 10:19         ` Kristian
2002-01-27 19:54           ` Ed Sweetman
2002-01-28  8:29             ` Andrew Morton
2002-01-28  9:51               ` benh
2002-01-28  9:51                 ` Andrew Morton
2002-01-28 15:50                   ` Ed Sweetman
2002-01-28 17:13                     ` Kristian
2002-01-28 13:51               ` Kristian
2002-01-28 19:21       ` Kevin P. Fleming
2002-01-26  8:43 ` Dan Chen
2002-01-26 12:03 ` Kristian
2002-01-27 21:21 ` Robert Love
2002-01-27 21:25   ` Jens Axboe
2002-01-27 21:36     ` Andrew Morton
2002-01-27 21:40     ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C53711B.F8D89811@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=kevin@labsysgrp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox