Could not compile md/raid5.c and md/multipath.c in 2.5.3-pre3

Could not compile md/raid5.c and md/multipath.c in 2.5.3-pre3

[Mingming cao]

Hello,

While compiling the clean 2.5.3-pre3 kernel I found the
drivers/md/raid5.c and drivers/md/multipatch.c could not get compiled.
Here is the compiling error for raid5.c: 

......
-D__KERNEL__ -I/home/ming/views/253-pre3/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686    -c -o raid5.o raid5.c
In file included from raid5.c:23:
/home/ming/views/253-pre3/include/linux/raid/raid5.h:218: parse error
before `md_wait_queue_head_t'
/home/ming/views/253-pre3/include/linux/raid/raid5.h:218: warning: no
semicolon
at end of struct or union
/home/ming/views/253-pre3/include/linux/raid/raid5.h:222: parse error
before `device_lock'
......


This failure also happened for 2.5.2 kernel.  Both of raid5.c and
multipatch.c use some data structures defined in md_compatible.h, which
was included in md.h before but does not exist under include/linux/raid
for now.  Could someone fix this?



-- 
Mingming Cao

Re: Could not compile md/raid5.c and md/multipath.c in 2.5.3-pre3

[Evgeniy Polyakov]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Tue, 29 Jan 2002 14:09:54 -0800
Mingming cao <cmm@us.ibm.com> wrote:

> Hello,

Good time of day.

> -march=i686    -c -o raid5.o raid5.c
> In file included from raid5.c:23:
> /home/ming/views/253-pre3/include/linux/raid/raid5.h:218: parse error
> before `md_wait_queue_head_t'
> /home/ming/views/253-pre3/include/linux/raid/raid5.h:218: warning: no
> semicolon
> at end of struct or union
> /home/ming/views/253-pre3/include/linux/raid/raid5.h:222: parse error
> before `device_lock'
> ......
> for now.  Could someone fix this?

I hope this patch will help you.

This patch is also cc'ed to Ingo Molnar, who is one of the maintainers of
multiple discs support. Is it right, Ingo?
Or noone should annoy anyone with such things?

> -- 
> Mingming Cao


	Evgeniy Polyakov ( s0mbre ).

[-- Attachment #2: include_linux_raid_md.diff --]
[-- Type: application/octet-stream, Size: 392 bytes --]

--- ./include/linux/raid/md.h~	Tue Jan 29 03:50:06 2002
+++ ./include/linux/raid/md.h	Wed Jan 30 04:12:14 2002
@@ -63,6 +63,9 @@
 #define MD_MINOR_VERSION                90
 #define MD_PATCHLEVEL_VERSION           0
 
+typedef wait_queue_head_t md_wait_queue_head_t;
+typedef spinlock_t md_spinlock_t;
+
 extern int md_size[MAX_MD_DEVS];
 extern struct hd_struct md_hd_struct[MAX_MD_DEVS];
 

Re: Could not compile md/raid5.c and md/multipath.c in 2.5.3-pre3

[Mingming cao]

Evgeniy Polyakov wrote:
> 
> On Tue, 29 Jan 2002 14:09:54 -0800
> Mingming cao <cmm@us.ibm.com> wrote:
> 
> > Hello,
> 
> Good time of day.
> 
> > -march=i686    -c -o raid5.o raid5.c
> > In file included from raid5.c:23:
> > /home/ming/views/253-pre3/include/linux/raid/raid5.h:218: parse error
> > before `md_wait_queue_head_t'
> > /home/ming/views/253-pre3/include/linux/raid/raid5.h:218: warning: no
> > semicolon
> > at end of struct or union
> > /home/ming/views/253-pre3/include/linux/raid/raid5.h:222: parse error
> > before `device_lock'
> > ......
> > for now.  Could someone fix this?
> 
> I hope this patch will help you.
> 
> This patch is also cc'ed to Ingo Molnar, who is one of the maintainers of
> multiple discs support. Is it right, Ingo?
> Or noone should annoy anyone with such things?
> 
Hello Evgeniy,

I omitted similar compile errors in the last email.  raid5.c and
multipath.c referenced a lot data structures defined in
md_compatible.h,  besides the two you added in your fix......

Thank you for your help.
-- 
Mingming Cao
IBM Linux Technology Center
503-578-5024  IBM T/L: 775-5024
cmm@us.ibm.com
http://www.ibm.com/linux/ltc

Re: Could not compile md/raid5.c and md/multipath.c in 2.5.3-pre3

[Evgeniy Polyakov]

On Tue, 29 Jan 2002 18:02:29 -0800
Mingming cao <cmm@us.ibm.com> wrote:

> I omitted similar compile errors in the last email.  raid5.c and
> multipath.c referenced a lot data structures defined in
> md_compatible.h,  besides the two you added in your fix......

As you mention md_compatible.h does not exist, it was introduced in 2.5.2
patch only in drivers/md/xor.c. But in at least pre5 all structures were
correctly defined in various md_{p,u,k}.h files. I've tried to find others
undefined symbols, but cann't. So i suggest you to upgrade a bit to pre6
or pre5 kernel ;), apply my litle patch and remove mention of
md_compatible.h in drivers/md/xor.c. And feel free to write all others
erorrs, if they will appear again.

> Thank you for your help.

Good luck.

> -- 
> Mingming Cao


	Evgeniy Polyakov ( s0mbre ).