2.5.3 Link Error

2.5.3 Link Error

[John Weber]

         -o vmlinux
fs/fs.o: In function `cap_info_llseek':
fs/fs.o(.text+0x4e1d1): undefined reference to `lock_kernel'
fs/fs.o(.text+0x4e220): undefined reference to `unlock_kernel'
fs/fs.o: In function `hdr_llseek':
fs/fs.o(.text+0x4e858): undefined reference to `lock_kernel'
fs/fs.o(.text+0x4e8b6): undefined reference to `unlock_kernel'
make: *** [vmlinux] Error 1

Re: 2.5.3 Link Error

[John Weber]

John Weber wrote:

>         -o vmlinux
> fs/fs.o: In function `cap_info_llseek':
> fs/fs.o(.text+0x4e1d1): undefined reference to `lock_kernel'
> fs/fs.o(.text+0x4e220): undefined reference to `unlock_kernel'
> fs/fs.o: In function `hdr_llseek':
> fs/fs.o(.text+0x4e858): undefined reference to `lock_kernel'
> fs/fs.o(.text+0x4e8b6): undefined reference to `unlock_kernel'
> make: *** [vmlinux] Error 1
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

I think this has something to do with <linux/smp_lock.h> not
being included somewhere in the HFS filesystem headers.

[PATCH] Re: 2.5.3 Link Error

[Robert Love]

iOn Wed, 2002-01-30 at 17:03, John Weber wrote:
>          -o vmlinux
> fs/fs.o: In function `cap_info_llseek':
> fs/fs.o(.text+0x4e1d1): undefined reference to `lock_kernel'
> fs/fs.o(.text+0x4e220): undefined reference to `unlock_kernel'
> fs/fs.o: In function `hdr_llseek':
> fs/fs.o(.text+0x4e858): undefined reference to `lock_kernel'
> fs/fs.o(.text+0x4e8b6): undefined reference to `unlock_kernel'
> make: *** [vmlinux] Error 1

Whoops, missed that in the BKL removal patch.  This should fix it.

Linus, please apply.

	Robert Love

diff -urN linux-2.5.3/fs/hfs/file_cap.c linux/fs/hfs/file_cap.c
--- linux-2.5.3/fs/hfs/file_cap.c	Wed Jan 30 16:12:03 2002
+++ linux/fs/hfs/file_cap.c	Wed Jan 30 17:08:09 2002
@@ -24,6 +24,7 @@
 #include <linux/hfs_fs_sb.h>
 #include <linux/hfs_fs_i.h>
 #include <linux/hfs_fs.h>
+#include <linux/smp_lock.h>
 
 /*================ Forward declarations ================*/
 static loff_t      cap_info_llseek(struct file *, loff_t,
diff -urN linux-2.5.3/fs/hfs/file_hdr.c linux/fs/hfs/file_hdr.c
--- linux-2.5.3/fs/hfs/file_hdr.c	Wed Jan 30 16:12:03 2002
+++ linux/fs/hfs/file_hdr.c	Wed Jan 30 17:10:31 2002
@@ -29,6 +29,7 @@
 #include <linux/hfs_fs_sb.h>
 #include <linux/hfs_fs_i.h>
 #include <linux/hfs_fs.h>
+#include <linux/smp_lock.h>
 
 /* prodos types */
 #define PRODOSI_FTYPE_DIR   0x0F