public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Ulrich Weigand <weigand@immd1.informatik.uni-erlangen.de>
Cc: velco@fadata.bg, linux-kernel@vger.kernel.org
Subject: Re: linux-kernel@vger.kernel.org
Date: Wed, 30 Jan 2002 17:11:01 -0800	[thread overview]
Message-ID: <3C5899A5.5A5F7272@zip.com.au> (raw)
In-Reply-To: <200201310102.CAA17256@faui1a.informatik.uni-erlangen.de>

Ulrich Weigand wrote:
> 
> Momchil Velikov wrote:
> 
> +int move_from_swap_cache(struct page *page, unsigned long index,
> +               struct address_space *mapping)
> +{
> +       void **pslot;
> +       int err;
> +
> +       if (!PageLocked(page))
> +               BUG();
> +
> +       spin_lock(&swapper_space.i_shared_lock);
> +       spin_lock(&mapping->i_shared_lock);
> +
> +       err = radix_tree_reserve(&mapping->page_tree, index, &pslot);
> +       if (!err) {
> +               swp_entry_t entry;
> +
> +               block_flushpage(page, 0);

block_flushpage inside spinlock is a no-no.  It does I/O,
and sleeps.

-

  reply	other threads:[~2002-01-31  1:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-31  1:02 linux-kernel@vger.kernel.org Ulrich Weigand
2002-01-31  1:11 ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-10-14  8:51 linux-kernel@vger.kernel.org Mustafa Ayvaz
2011-01-24 16:43 linux-kernel@vger.kernel.org sen wang
2010-05-29 11:22 linux-kernel@vger.kernel.org uwaysi.bin.kareem
2009-10-11  6:22 linux-kernel@vger.kernel.org Boyan
     [not found] <de72ca4e0905172314q3c55ec52ic9ab762a0352a91d@mail.gmail.com>
2009-05-18  7:06 ` linux-kernel@vger.kernel.org Sudarshan Soma
2008-03-09 17:02 linux-kernel@vger.kernel.org bruno.roussel
2007-08-14  9:58 linux-kernel@vger.kernel.org bizu
2007-08-14  9:58 linux-kernel@vger.kernel.org bizu
2005-07-05 13:58 Linux-kernel@vger.kernel.org linux-kernel
2004-07-26 15:44 linux-kernel@vger.kernel.org rap
2004-07-26 14:48 LINUX-KERNEL@VGER.KERNEL.ORG Returned mail
2004-06-21  9:19 linux-kernel@vger.kernel.org Romia Fersi
2003-06-18 21:46 linux-kernel@vger.kernel.org David Mosberger
2002-10-30 17:57 linux-kernel@vger.kernel.org Manfred Spraul
2002-10-30 21:22 ` linux-kernel@vger.kernel.org Bill Davidsen
2002-09-30  1:13 linux-kernel@vger.kernel.org omit_ECE
2002-09-30  1:18 ` linux-kernel@vger.kernel.org David S. Miller
2002-09-30  1:39 ` linux-kernel@vger.kernel.org Jeff Chua
2001-05-25 12:42 linux-kernel@vger.kernel.org Julien Laganier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C5899A5.5A5F7272@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=velco@fadata.bg \
    --cc=weigand@immd1.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox