From: Martin Wirth <Martin.Wirth@dlr.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5: push BKL out of llseek
Date: Thu, 31 Jan 2002 16:39:31 +0100 [thread overview]
Message-ID: <3C596533.488F1470@dlr.de> (raw)
On 30 Jan 2002, Martin Wirth wrote:
>
>void combi_mutex_lock(struct combilock *x)
.....
> } else <---
> x->owner=current;
> spin_unlock(&x->wait.lock);
Uugh, the else is wrong of course. The owner has to be set in any
case.(Just deleted some debugging code and reformatted a bit to quick
:))
A further note: Although the combilock shares some advantages with a
spin-lock (no unnecessary scheduling for short time locking) it may
behave like a semaphore on entry also if you call combi_spin_lock.
For example
spin_lock(&slock);
combi_spin_lock(&clock);
is a BUG because combi_spin_lock may sleep while holding slock!
Would be nice if there were some comments.
Martin Wirth
next reply other threads:[~2002-01-31 15:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-31 15:39 Martin Wirth [this message]
2002-01-31 21:06 ` [PATCH] 2.5: push BKL out of llseek Nigel Gamble
-- strict thread matches above, loose matches on Subject: below --
2002-02-01 19:29 John Hawkes
2002-01-30 21:14 Martin Wirth
2002-01-30 0:00 Robert Love
2002-01-30 0:09 ` Linus Torvalds
2002-01-30 0:41 ` Robert Love
2002-01-30 0:52 ` Linus Torvalds
2002-01-30 2:24 ` Robert Love
2002-01-30 1:26 ` Andrew Morton
2002-01-30 2:16 ` Linus Torvalds
2002-01-30 2:20 ` Robert Love
2002-01-30 2:20 ` Andrew Morton
2002-01-30 2:21 ` Dave Jones
2002-01-30 2:37 ` Robert Love
2002-01-30 2:50 ` Nigel Gamble
2002-01-30 3:19 ` Andrew Morton
2002-01-30 9:34 ` Nigel Gamble
2002-01-30 10:36 ` Russell King
2002-01-30 4:54 ` Alexander Viro
2002-01-30 8:00 ` Trond Myklebust
2002-01-30 13:39 ` Robert Love
2002-01-30 4:50 ` Anton Blanchard
2002-01-30 5:03 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C596533.488F1470@dlr.de \
--to=martin.wirth@dlr.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox