From: Todor Todorov <ttodorov@web.de>
To: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: 2.5.3-dj1: zisofs compile fix
Date: Sat, 02 Feb 2002 17:26:14 +0000 [thread overview]
Message-ID: <3C5C2136.5020202@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
Hello there,
I had the problem compiling 2.5.3-dj1 with zisofs included as other
people on that list - same problem, undefined reference in fs/fs.o . I
tried to use the EXPORTS_SYMBOL macro from modules.h and export the
zisofs_cleanup in fs/isofs/compress.c and also added export-objs :=
compress.o in the Makefile. Didn't help. Searching for hints in other
Makefiles which list objects exporting symbols, i noticed that all such
objects are linked first into the target obj, which is not the case with
compress.o. When I moved compress.o first in the obj-y list, the compile
error was gone and this even without EXPORT_SYMBOL(zisofs_cleanup); in
compress.c
Next to say is: I don't know anything about the linux kernel, so I'm not
sure if this is the correct way to fix this issue. It just seems to
work. So use at your own risk until the maintainer fixes it properly.
Cheers,
Todor
[-- Attachment #2: zisofs-compilefix-2.5.3-dj1.patch --]
[-- Type: text/plain, Size: 524 bytes --]
--- linux-2.5.3-dj1/fs/isofs/Makefile Sat Feb 2 10:59:07 2002
+++ linux/fs/isofs/Makefile Sat Feb 2 16:52:59 2002
@@ -9,9 +9,16 @@
O_TARGET := isofs.o
-obj-y := namei.o inode.o dir.o util.o rock.o
+ifeq ( $(CONFIG_ZISOFS), y )
+ obj-y := compress.o namei.o inode.o dir.o util.o rock.o
+endif
+
+ifeq ( $(CONFIG_ZISOFS), n )
+ obj-y := namei.o inode.o dir.o util.o rock.o
+endif
+
obj-$(CONFIG_JOLIET) += joliet.o
-obj-$(CONFIG_ZISOFS) += compress.o
+#obj-$(CONFIG_ZISOFS) += compress.o
obj-m := $(O_TARGET)
reply other threads:[~2002-02-02 16:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C5C2136.5020202@web.de \
--to=ttodorov@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox