public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: george anzinger <george@mvista.com>
To: Mike Fedyk <mfedyk@matchmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] larger kernel stack (8k->16k) per task
Date: Fri, 08 Feb 2002 23:17:06 -0800	[thread overview]
Message-ID: <3C64CCF2.124684D@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0202081645170.1359-100000@einstein.homenet> <d3eljvlo5u.fsf@lxplus052.cern.ch> <20020208211221.GB343@mis-mike-wstn>

Mike Fedyk wrote:
> 
> On Fri, Feb 08, 2002 at 09:22:05PM +0100, Jes Sorensen wrote:
> > Tigran Aivazian <tigran@veritas.com> writes:
> >
> > > So, I found this patch useful at least for debugging. Moreover, I think it
> > > would be very useful to have it in Linus' kernel as a CONFIG_ option so
> > > that if people complain about random memory corruption then they can try
> > > to reproduce it with larger stack and then (with aid of /proc/stack) the
> > > offender is found and fixed. I cc'd Alan; if he thinks this is a bad idea
> > > I would be interested to know why.
> >
> > Well as someone suggested, stick it under CONFIG_SLAB_DEBUG then, it
> 
> That was suggested by Andrew Morton...
> 
> > surely shouldn't be an option to be enabled in normal production
> > kernels but for debugging it's fine.
> >
> 
> Ahh, but if you are overflowing the stack by a few bytes, and then enable
> stack debugging the error will go away because of the alrger stack.

It really isn't that hard (or expensive) to put a stack overflow test in
entry.S.  Of course this should be a debug config option.

George
> 
> If this goes in, it should have its own config option.
> 
> Mike
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
George           george@mvista.com
High-res-timers: http://sourceforge.net/projects/high-res-timers/
Real time sched: http://sourceforge.net/projects/rtsched/

  reply	other threads:[~2002-02-09  7:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-08 16:06 [patch] larger kernel stack (8k->16k) per task Tigran Aivazian
2002-02-08 16:09 ` Arjan van de Ven
2002-02-08 16:59   ` Tigran Aivazian
2002-02-08 16:57     ` Arjan van de Ven
2002-02-08 17:23     ` Arjan van de Ven
2002-02-08 18:16       ` Alan Cox
2002-02-08 18:29       ` Richard B. Johnson
2002-02-08 18:38         ` Arjan van de Ven
2002-02-08 20:54         ` Ingo Molnar
2002-02-08 18:15     ` Alan Cox
2002-02-08 20:22     ` Jes Sorensen
2002-02-08 21:12       ` Mike Fedyk
2002-02-09  7:17         ` george anzinger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-02-08 15:20 Tigran Aivazian
2002-02-08 15:36 ` Arjan van de Ven
2002-02-08 15:43 ` Rik van Riel
2002-02-08 15:52 ` Alan Cox
2002-02-08 20:08 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C64CCF2.124684D@mvista.com \
    --to=george@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfedyk@matchmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox