Re: another IDE cleanup: kill duplicated code

Andre Hedrick
2002-02-13T05:58:29Z

On Tue, 12 Feb 2002, Jens Axboe wrote:

> On Tue, Feb 12 2002, Vojtech Pavlik wrote:
> > On Tue, Feb 12, 2002 at 02:17:48PM +0100, Martin Dalecki wrote:
> >
> > > So the conclusions is that not just the read_ahead array is bogous now.
> > > The max_readahead array can be killed entierly from the kernel as well ;-).
> > >
> > > The answer is: I'm now confident that you can just remove all the
> > > max_readahead initialization from the ide code.
> >
> > Since I've come to the same conclusion, here is the patch. It removes
> > read_ahead, max_readahead, BLKRAGET, BLKRASET, BLKFRAGET and BLKFRASET
> > completely.
> >
> > Comments, Jens?
>
> Could you battle it out, and I'll take a good look at the patch
> tomorrow :-). I'm all for a bit of spring cleaning here, it's needed it
> badly for quite a while.

Basically the LOT of all of you are WRONG and quit submitting patches to
try and dork up the works. Since we already have added back one ratehole
from 2.4 that Linus strictly forbid, I am glad to see everyone here is an
expert!

I just love how the copy of a request has worked its way back into to the
code-base. :-/ I recall Linus stating it was/is a horrid mess.

Regards,

Andre Hedrick
Linux Disk Certification Project Linux ATA Development