Re: another IDE cleanup: kill duplicated code

Andre Hedrick
2002-02-13T07:41:35Z

On Wed, 13 Feb 2002, Jens Axboe wrote:

> On Tue, Feb 12 2002, Andre Hedrick wrote:
> > I just love how the copy of a request has worked its way back into to the
> > code-base. :-/ I recall Linus stating it was/is a horrid mess.
>
> The copy itself is not the horrid mess, the handling of multi write is
> what is the horrible mess. Having a private copy to mess with is pretty
> much a necessity IMO if you want to handle > current_nr_sectors at the
> time without completing it chunk by chunk.

Exactly, and I am about to have a valid clean solution that is short and
proper. Now that I have the handler working, I need to have the one walk
function to do the bio indexing. Also it is less than 30 lines.

Not the stuff you added as an interm fix :-/

You know why these changes people are pushing are wrong, because it is way
to early to being the compression code process.

Cheers,

Andre Hedrick
Linux Disk Certification Project Linux ATA Development