Re: another IDE cleanup: kill duplicated code

Andrew Morton
2002-02-14T10:20:48Z

Martin Dalecki wrote:
>
> >The file_readahead setting works as expected and as desired. Or at
> >least it did a few weeks ago.
> >
> The few weeks ago thing matters. It doesn't any longer.
>

Please explain, in detail, why /proc/ide/hdX/settings:file_readhead
no longer controls the readhead for that device. If this is
the case in thr current 2.4 kernel, or if it will become the
case if/when the IDE patches are merged then that needs fixing.

Look, I agree that the current readhead controls are junk, and
do not belong in the driver layer at all. All I'm saying is
that we need per-device controls, for whatever scheme we end
up using for readhead in 2.5. We really don't want to have
the same sized readhead for CDROMs, floppies and super-duper
RAID arrays.

-