Re: another IDE cleanup: kill duplicated code

Martin Dalecki
2002-02-13T10:48:33Z

Andrew Morton wrote:

>Martin Dalecki wrote:
>
>>If you are already at it, I would like to ask to you consider seriously
>>the removal of the
>>following entries in the ide drivers /proc control files:
>>
>> ide_add_setting(drive, "breada_readahead", ... 1,
>>2, &read_ahead[major], NULL);
>> ide_add_setting(drive, "file_readahead", ...
>>&max_readahead[major][minor], NULL);
>>
>>Those calls can be found in ide-cd.c, ide-disk,c and ide-floppy.c
>>
>
>I suspect that if we remove these, we'll one day end up putting them back.
>It is appropriate that we be able to control readahead characteristics
>on a per-device and per-technology basis.
>
You are missing one simple thing: The removed values doen't control
ANYTHING!