Re: [PATCH] 2.5.5 IDE cleanup 11

Andre Hedrick
2002-02-21T21:42:51Z

[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]

Alan,

Sorry I forgot to include the patch.

Andre Hedrick
Linux Disk Certification Project Linux ATA Development

On Thu, 21 Feb 2002, Andre Hedrick wrote:

> On Thu, 21 Feb 2002, Alan Cox wrote:
>
> > > This is the next round of IDE driver cleanups.
> >
> > How about fixing the stuff you've already messed up (like putting the
> > drive present flags and the probe return back) ? The changes you made
> > to the init code also broke the framework so that 2.5 would eventually
> > let you do
> >
> > open("/dev/cdrom")
> > read/write
> > close("/dev/cdrom")
> > open("/dev/sda") /* Same device */
> > burn a cd
> >
> > without loading/unloading modules
> >
> > I'm also confused how you plan to fix the hot swap case after your changes
> > because you've not allowed for the fact drives might be hot swapped while
> > you are suspended. The old code was careful to keep the hooks for that
> > ready.
> >
> > Finally you forgot to update the MAINTAINER entry since you've now clearly
> > decided to walk over Andre and become the IDE maintainer
> >
> > Alan
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
> Alan,
>
> Please let me correct this issue as now I am going to start new driver
> since this one is now beyond repair for me.
>
> Regards,
>
> Andre Hedrick
> Linux Disk Certification Project Linux ATA Development
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

[-- Attachment #2: Type: text/plain, Size: 984 bytes --]

--- linux-2.5.5-pristine/MAINTAINERS.orig Thu Feb 21 13:26:44 2002
+++ linux-2.5.5-pristine/MAINTAINERS Thu Feb 21 13:30:56 2002
@@ -697,13 +697,9 @@
S: Supported

IDE DRIVER [GENERAL]
-P: Andre Hedrick
-M: andre@linux-ide.org
-M: andre@linuxdiskcert.org
+P: Martin Dalecki
+M: Martin Dalecki <dalecki@evision-ventures.com>
L: linux-kernel@vger.kernel.org
-W: http://www.kernel.org/pub/linux/kernel/people/hedrick/
-W: http://www.linux-ide.org/
-W: http://www.linuxdiskcert.org/
S: Maintained

IDE/ATAPI CDROM DRIVER
@@ -1523,6 +1519,16 @@
L: vtun@office.satix.net
W: http://vtun.sourceforge.net/tun
S: Maintained
+
+SATA/PATA/ACB DRIVER [ALL]
+P: Andre Hedrick
+M: andre@linux-ide.org
+M: andre@linuxdiskcert.org
+L: linux-kernel@vger.kernel.org
+W: http://www.kernel.org/pub/linux/kernel/people/hedrick/
+W: http://www.linux-ide.org/
+W: http://www.linuxdiskcert.org/
+S: Future Creation

U14-34F SCSI DRIVER
P: Dario Ballabio