From: Manfred Spraul <manfred@colorfullife.com>
To: Robert Love <rml@tech9.net>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: [PATCH] 2.5: further llseek cleanup (3/3)
Date: Sat, 16 Feb 2002 23:31:38 +0100 [thread overview]
Message-ID: <3C6EDDCA.DAB884BD@colorfullife.com> (raw)
Hi Robert,
I think the pcilynx change is wrong:
> - if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) return
> -EINVAL;
> + if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) {
> + lock_kernel();
^^^^^^ unlock_kernel()?
> + return -EINVAL;
> + }
>
> file->f_pos = newoffs;
^^^^^^^^^^^^^^^^^^^ where is the unlock here?
> return newoffs;
--
Manfred
next reply other threads:[~2002-02-16 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-16 22:31 Manfred Spraul [this message]
2002-02-16 23:00 ` [PATCH] Re: 2.5: further llseek cleanup (3/3) Robert Love
2002-02-16 23:20 ` Robert Love
-- strict thread matches above, loose matches on Subject: below --
2002-01-31 17:11 [PATCH] " Robert Love
2002-01-31 18:02 ` Guillaume Chamberland-Larose
2002-01-31 21:47 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C6EDDCA.DAB884BD@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox