Re: [DRIVER][RFC] SC1200 Watchdog driver

Zwane Mwaikambo
2002-02-21T14:39:00Z

On Thu, 21 Feb 2002, Alan Cox wrote:

> Aside from the other comments Jeff made its got one bug that I only noticed
> because I fixed it in a pile of other stuff 8)
> open
> fork
> ioctl from two processes one per cpu at the same time

Thats a nice one =)

> NOWAYOUT support is missing - trivial to fix. Just remember to MOD_INC_USE..
> on the nowayout path

*Added to the TODO*

> Alan in pedantic mode

Thanks Alan and Jeff for the input, i'll cleanup this stuff. Out of
interest, do we normally take in patches for specialised embedded boxes? I
see the AMD Elan stuff got in but that only touched one area and was easy
to integrate. I presume they'd get accepted if the code was broken up into
seperate modules instead of being overly specialised. For example, the
CRIS stuff in the Etrax tree (developer.axis.com).

Regards,
Zwane Mwaikambo