Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Michael Cohen]

This is the fourth (there were two seconds with different contents, oops) of several mails containing patches to be included in 2.4.19.  Some are worthy of dicussion prior to inclusion and have been marked as such.  The majority of these patches were found on lkml; the remaining ones have URLs listed.

The origin of this patch is unknown, but it is believed to be from lkml.

------
Michael Cohen
OhDarn.net

--- linux.orig/drivers/video/riva/fbdev.c	Wed Nov 14 14:52:20 2001
+++ linux/drivers/video/riva/fbdev.c	Tue Nov 27 17:37:02 2001
@@ -1703,11 +1703,31 @@
 {
 	unsigned char tmp, vesa;
 	struct rivafb_info *rinfo = (struct rivafb_info *)info;
+	struct fb_cmap cmap;
+	u16 black[16];
 
 	DPRINTK("ENTER\n");
 
 	assert(rinfo != NULL);
 
+	/*
+	 * FIXME: X seems to have some issues with this particular hardware
+	 * method of blanking.. so we use a software fallback for now, pending
+	 * a real fix. (Someone with documentation might want to fix this
+	 * properly).
+	 */
+	if (blank) {
+		memset(black, 0, 16 * sizeof(u16));
+		cmap.red = black;
+		cmap.green = black;
+		cmap.blue = black;
+		cmap.transp = NULL;
+		cmap.start = 0;
+		cmap.len = sizeof(black) / sizeof(u16);
+		fb_set_cmap(&cmap, 1, riva_setcolreg, info);
+	}
+
+#if 0
 	tmp = SEQin(rinfo, 0x01) & ~0x20;	/* screen on/off */
 	vesa = CRTCin(rinfo, 0x1a) & ~0xc0;	/* sync on/off */
 
@@ -1730,6 +1750,7 @@
 
 	SEQout(rinfo, 0x01, tmp);
 	CRTCout(rinfo, 0x1a, vesa);
+#endif
 
 	DPRINTK("EXIT\n");
 }

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Marcelo Tosatti]

Please send that to the RivaFB maintainer.

On Mon, 25 Feb 2002, Michael Cohen wrote:

> 
> This is the fourth (there were two seconds with different contents, oops) of several mails containing patches to be included in 2.4.19.  Some are worthy of dicussion prior to inclusion and have been marked as such.  The majority of these patches were found on lkml; the remaining ones have URLs listed.
> 
> The origin of this patch is unknown, but it is believed to be from lkml.

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Jeff Garzik]

Marcelo Tosatti wrote:
> Please send that to the RivaFB maintainer.

to be honest there really isn't one.....

-- 
Jeff Garzik      | "UNIX enhancements aren't."
Building 1024    |           -- says /usr/games/fortune
MandrakeSoft     |

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Marcelo Tosatti]

Yes there is: Ani Joshi <ajoshi@shell.unixbox.com>.

On Wed, 27 Feb 2002, Jeff Garzik wrote:

> Marcelo Tosatti wrote:
> > Please send that to the RivaFB maintainer.
> 
> to be honest there really isn't one.....

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Marcelo Tosatti]

On Thu, 28 Feb 2002, Jeff Garzik wrote:

> Marcelo Tosatti wrote:
> > On Wed, 27 Feb 2002, Jeff Garzik wrote:
> > > Marcelo Tosatti wrote:
> > > > Please send that to the RivaFB maintainer.
> 
> > > to be honest there really isn't one.....
> 
> > Yes there is: Ani Joshi <ajoshi@shell.unixbox.com>.
> 
> No, there isn't.  Ani volunteered for the position, then has been
> ignoring patches sent to him for a year or more.   I used to be rivafb
> maintainer (look at who wrote riva/fbdev.c...), then didn't have time. 
> When I asked around for a new maintainer, he claimed to take up the
> position, but no patches have been forthcoming...
> 
> Ferenc Bakonyi did a good bit of work, and IMO would be a good candidate
> for maintainership, if he's still around.

I've been receing rivafb patches from him lately. For example, pre2 has a
rivafb update.

In practice, from my point of view, he is maintaining the driver.

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Jeff Garzik]

Marcelo Tosatti wrote:
> On Wed, 27 Feb 2002, Jeff Garzik wrote:
> > Marcelo Tosatti wrote:
> > > Please send that to the RivaFB maintainer.

> > to be honest there really isn't one.....

> Yes there is: Ani Joshi <ajoshi@shell.unixbox.com>.

No, there isn't.  Ani volunteered for the position, then has been
ignoring patches sent to him for a year or more.   I used to be rivafb
maintainer (look at who wrote riva/fbdev.c...), then didn't have time. 
When I asked around for a new maintainer, he claimed to take up the
position, but no patches have been forthcoming...

Ferenc Bakonyi did a good bit of work, and IMO would be a good candidate
for maintainership, if he's still around.

	Jeff



P.S. Not to knock Ani Joshi himself -- I have many cheers for him, he
got my S3 cards working under XFree 4.0!

-- 
Jeff Garzik      | "UNIX enhancements aren't."
Building 1024    |           -- says /usr/games/fortune
MandrakeSoft     |

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Jeff Garzik]

Marcelo Tosatti wrote:
> 
> On Thu, 28 Feb 2002, Jeff Garzik wrote:
> 
> > Marcelo Tosatti wrote:
> > > On Wed, 27 Feb 2002, Jeff Garzik wrote:
> > > > Marcelo Tosatti wrote:
> > > > > Please send that to the RivaFB maintainer.
> >
> > > > to be honest there really isn't one.....
> >
> > > Yes there is: Ani Joshi <ajoshi@shell.unixbox.com>.
> >
> > No, there isn't.  Ani volunteered for the position, then has been
> > ignoring patches sent to him for a year or more.   I used to be rivafb
> > maintainer (look at who wrote riva/fbdev.c...), then didn't have time.
> > When I asked around for a new maintainer, he claimed to take up the
> > position, but no patches have been forthcoming...
> >
> > Ferenc Bakonyi did a good bit of work, and IMO would be a good candidate
> > for maintainership, if he's still around.
> 
> I've been receing rivafb patches from him lately. For example, pre2 has a
> rivafb update.
> 
> In practice, from my point of view, he is maintaining the driver.

That's great!

I'm glad he's returned.

	Jeff



-- 
Jeff Garzik      | "UNIX enhancements aren't."
Building 1024    |           -- says /usr/games/fortune
MandrakeSoft     |

Re: Submissions for 2.4.19-pre [RivaFB Blanking Fix (Author Unknown)]

[Ani Joshi]

On Thu, 28 Feb 2002, Jeff Garzik wrote:

> That's great!
>
> I'm glad he's returned.
>


I never went anywhere.  Blindly pushing patches into a driver isn't called
"maintaining"...



ani