From: Ben Greear <greearb@candelatech.com>
To: linux-kernel@vger.kernel.org
Cc: jgarzik@mandrakesoft.com
Subject: Re: Various 802.1Q VLAN driver patches. [try3]
Date: Fri, 01 Mar 2002 10:14:25 -0700 [thread overview]
Message-ID: <3C7FB6F1.1040801@candelatech.com> (raw)
In-Reply-To: <20020301.072831.120445660.davem@redhat.com> <3C7FA81A.3070602@candelatech.com> <20020301.081110.76328637.davem@redhat.com> <3C7FAC00.4010402@candelatech.com> <20020301183059.V23151@mea-ext.zmailer.org>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Ok, tulip patch attached as hopefully a plain-text attachment.
The 3com link has already been sent, and the eepro100 patch
was short enough not to wrap.
Thanks for your patience.
Matti Aarnio wrote:
> No, it does not.
>
> On Fri, Mar 01, 2002 at 09:27:44AM -0700, Ben Greear wrote:
>
>>User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4) Gecko/20011019 Netscape6/6.2
>>
>
> You MIGHT be able to send the patches as ATTACHMENTS.
> I think Uncle DaveM will accept them, while Linus dislikes them immensely.
>
> /Matti Aarnio
>
>
--
Ben Greear <greearb@candelatech.com> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
[-- Attachment #2: tulip_vlan.patch --]
[-- Type: text/plain, Size: 1894 bytes --]
diff -u --recursive --new-file linux/drivers/net/tulip/interrupt.c linux.dev/drivers/net/tulip/interrupt.c
--- linux/drivers/net/tulip/interrupt.c Fri Nov 9 22:45:35 2001
+++ linux.dev/drivers/net/tulip/interrupt.c Tue Dec 11 09:24:36 2001
@@ -128,8 +128,8 @@
dev->name, entry, status);
if (--rx_work_limit < 0)
break;
- if ((status & 0x38008300) != 0x0300) {
- if ((status & 0x38000300) != 0x0300) {
+ if ((status & (0x38000000 | RxDescFatalErr | RxWholePkt)) != RxWholePkt) {
+ if ((status & (0x38000000 | RxWholePkt)) != RxWholePkt) {
/* Ingore earlier buffers. */
if ((status & 0xffff) != 0x7fff) {
if (tulip_debug > 1)
@@ -155,10 +155,10 @@
struct sk_buff *skb;
#ifndef final_version
- if (pkt_len > 1518) {
+ if (pkt_len > 1522) {
printk(KERN_WARNING "%s: Bogus packet size of %d (%#x).\n",
dev->name, pkt_len, pkt_len);
- pkt_len = 1518;
+ pkt_len = 1522;
tp->stats.rx_length_errors++;
}
#endif
diff -u --recursive --new-file linux/drivers/net/tulip/tulip.h linux.dev/drivers/net/tulip/tulip.h
--- linux/drivers/net/tulip/tulip.h Fri Nov 9 22:45:35 2001
+++ linux.dev/drivers/net/tulip/tulip.h Tue Dec 11 09:24:36 2001
@@ -186,7 +186,7 @@
enum desc_status_bits {
DescOwned = 0x80000000,
- RxDescFatalErr = 0x8000,
+ RxDescFatalErr = 0x4842,
RxWholePkt = 0x0300,
};
diff -u --recursive --new-file linux/drivers/net/tulip/tulip_core.c linux.dev/drivers/net/tulip/tulip_core.c
--- linux/drivers/net/tulip/tulip_core.c Tue Nov 20 00:19:42 2001
+++ linux.dev/drivers/net/tulip/tulip_core.c Tue Dec 11 09:24:36 2001
@@ -63,7 +63,7 @@
#if defined(__alpha__) || defined(__arm__) || defined(__hppa__) \
|| defined(__sparc_) || defined(__ia64__) \
|| defined(__sh__) || defined(__mips__)
-static int rx_copybreak = 1518;
+static int rx_copybreak = 1522;
#else
static int rx_copybreak = 100;
#endif
next prev parent reply other threads:[~2002-03-01 17:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 15:28 [BETA-0.93] Fourth test release of Tigon3 driver David S. Miller
2002-03-01 16:11 ` Various 802.1Q VLAN driver patches Ben Greear
2002-03-01 16:11 ` David S. Miller
2002-03-01 16:27 ` Various 802.1Q VLAN driver patches. [try2] Ben Greear
2002-03-01 16:30 ` Matti Aarnio
2002-03-01 16:33 ` Randy.Dunlap
2002-03-01 16:42 ` Jeff Garzik
2002-03-01 17:14 ` Ben Greear [this message]
2002-03-01 19:24 ` Various 802.1Q VLAN driver patches. [try3] Jeff Garzik
2002-03-01 16:35 ` Various 802.1Q VLAN driver patches. [try2] Jeff Garzik
2002-03-01 16:46 ` Andreas Ferber
2002-03-01 18:45 ` Andrew Morton
2002-03-01 18:50 ` David S. Miller
2002-03-01 19:02 ` Jeff Garzik
2002-03-01 21:00 ` Alan Cox
2002-03-01 20:53 ` Jeff Garzik
2002-03-01 21:10 ` David S. Miller
2002-03-01 19:09 ` Jeff Garzik
2002-03-01 20:34 ` Andreas Ferber
2002-03-01 20:51 ` Jeff Garzik
2002-03-01 21:19 ` Ben Greear
2002-03-01 21:19 ` David S. Miller
2002-03-01 21:51 ` Andreas Ferber
2002-03-01 16:40 ` David S. Miller
2002-03-01 19:17 ` Various 802.1Q VLAN driver patches Jeff Garzik
2002-03-01 19:44 ` Patrick Schaaf
2002-03-01 19:43 ` Jeff Garzik
2002-03-03 20:16 ` Teodor Iacob
2002-03-01 20:27 ` Donald Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C7FB6F1.1040801@candelatech.com \
--to=greearb@candelatech.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox