From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: "David S. Miller" <davem@redhat.com>
Cc: akpm@zip.com.au, aferber@techfak.uni-bielefeld.de,
greearb@candelatech.com, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: Various 802.1Q VLAN driver patches. [try2]
Date: Fri, 01 Mar 2002 14:02:49 -0500 [thread overview]
Message-ID: <3C7FD059.E88C026F@mandrakesoft.com> (raw)
In-Reply-To: <3C7FADBB.3A5B338F@mandrakesoft.com> <20020301174619.A6125@devcon.net> <3C7FCC53.4E270646@zip.com.au> <20020301.105057.75255265.davem@redhat.com>
"David S. Miller" wrote:
>
> From: Andrew Morton <akpm@zip.com.au>
> Date: Fri, 01 Mar 2002 10:45:39 -0800
>
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
>
> Is this avoidable somehow?
>
> It's stupid to have all the overhead when vlans aren't even
> being built into the kernel.
>
> That was my original impetus.
>
> It's costly in some cases, when you have the TXDs on the chip
> you can avoid an entire PIO for each packet.
I'm pretty sure Andrew realizes this. I can see two valid complaints,
1) you don't need ugly ifdefs in the code itself -- define a no-op
static inline function for when !VLAN
2) IIRC Alan or somebody is trying to get rid of CONFIG_xxx_MODULE,
because it doesn't really cover the case of when somebody builds VLAN
"later on" as a module, but disables it initially.
--
Jeff Garzik |
Building 1024 |
MandrakeSoft | Choose life.
next prev parent reply other threads:[~2002-03-01 19:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 15:28 [BETA-0.93] Fourth test release of Tigon3 driver David S. Miller
2002-03-01 16:11 ` Various 802.1Q VLAN driver patches Ben Greear
2002-03-01 16:11 ` David S. Miller
2002-03-01 16:27 ` Various 802.1Q VLAN driver patches. [try2] Ben Greear
2002-03-01 16:30 ` Matti Aarnio
2002-03-01 16:33 ` Randy.Dunlap
2002-03-01 16:42 ` Jeff Garzik
2002-03-01 17:14 ` Various 802.1Q VLAN driver patches. [try3] Ben Greear
2002-03-01 19:24 ` Jeff Garzik
2002-03-01 16:35 ` Various 802.1Q VLAN driver patches. [try2] Jeff Garzik
2002-03-01 16:46 ` Andreas Ferber
2002-03-01 18:45 ` Andrew Morton
2002-03-01 18:50 ` David S. Miller
2002-03-01 19:02 ` Jeff Garzik [this message]
2002-03-01 21:00 ` Alan Cox
2002-03-01 20:53 ` Jeff Garzik
2002-03-01 21:10 ` David S. Miller
2002-03-01 19:09 ` Jeff Garzik
2002-03-01 20:34 ` Andreas Ferber
2002-03-01 20:51 ` Jeff Garzik
2002-03-01 21:19 ` Ben Greear
2002-03-01 21:19 ` David S. Miller
2002-03-01 21:51 ` Andreas Ferber
2002-03-01 16:40 ` David S. Miller
2002-03-01 19:17 ` Various 802.1Q VLAN driver patches Jeff Garzik
2002-03-01 19:44 ` Patrick Schaaf
2002-03-01 19:43 ` Jeff Garzik
2002-03-03 20:16 ` Teodor Iacob
2002-03-01 20:27 ` Donald Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C7FD059.E88C026F@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=aferber@techfak.uni-bielefeld.de \
--cc=akpm@zip.com.au \
--cc=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox