From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andreas Ferber <aferber@techfak.uni-bielefeld.de>
Cc: Ben Greear <greearb@candelatech.com>,
"David S. Miller" <davem@redhat.com>,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
zab@zabbo.net
Subject: Re: Various 802.1Q VLAN driver patches. [try2]
Date: Fri, 01 Mar 2002 14:09:23 -0500 [thread overview]
Message-ID: <3C7FD1E3.800A61FD@mandrakesoft.com> (raw)
In-Reply-To: <20020301.072831.120445660.davem@redhat.com> <3C7FA81A.3070602@candelatech.com> <20020301.081110.76328637.davem@redhat.com> <3C7FAC00.4010402@candelatech.com> <3C7FADBB.3A5B338F@mandrakesoft.com> <20020301174619.A6125@devcon.net>
Andreas Ferber wrote:
> The 3c59x one is available on
> http://www.myipv6.de/patches/vlan/3c59x.c-8021q.patch
Comments:
1) This patch is (like I mentioned earlier) for reference only, not for
application. It is really halfway in between software and hardware VLAN
support.
2) You don't want to set_8021q_mode if VLAN is not active. It's silly
to activate it when VLAN is compiled as a module but no one is using
vlans. That's going to be THE common case, because distros will
inevitably build the VLAN module with their stock kernel.
3) 3c59x needs real dev->change_mtu support. This patch provides the
info needed to do that... but doesn't do that.
4) It uses magic numbers instead of ETH_DATA_LEN and ETH_HLEN
--
Jeff Garzik |
Building 1024 |
MandrakeSoft | Choose life.
next prev parent reply other threads:[~2002-03-01 19:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 15:28 [BETA-0.93] Fourth test release of Tigon3 driver David S. Miller
2002-03-01 16:11 ` Various 802.1Q VLAN driver patches Ben Greear
2002-03-01 16:11 ` David S. Miller
2002-03-01 16:27 ` Various 802.1Q VLAN driver patches. [try2] Ben Greear
2002-03-01 16:30 ` Matti Aarnio
2002-03-01 16:33 ` Randy.Dunlap
2002-03-01 16:42 ` Jeff Garzik
2002-03-01 17:14 ` Various 802.1Q VLAN driver patches. [try3] Ben Greear
2002-03-01 19:24 ` Jeff Garzik
2002-03-01 16:35 ` Various 802.1Q VLAN driver patches. [try2] Jeff Garzik
2002-03-01 16:46 ` Andreas Ferber
2002-03-01 18:45 ` Andrew Morton
2002-03-01 18:50 ` David S. Miller
2002-03-01 19:02 ` Jeff Garzik
2002-03-01 21:00 ` Alan Cox
2002-03-01 20:53 ` Jeff Garzik
2002-03-01 21:10 ` David S. Miller
2002-03-01 19:09 ` Jeff Garzik [this message]
2002-03-01 20:34 ` Andreas Ferber
2002-03-01 20:51 ` Jeff Garzik
2002-03-01 21:19 ` Ben Greear
2002-03-01 21:19 ` David S. Miller
2002-03-01 21:51 ` Andreas Ferber
2002-03-01 16:40 ` David S. Miller
2002-03-01 19:17 ` Various 802.1Q VLAN driver patches Jeff Garzik
2002-03-01 19:44 ` Patrick Schaaf
2002-03-01 19:43 ` Jeff Garzik
2002-03-03 20:16 ` Teodor Iacob
2002-03-01 20:27 ` Donald Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C7FD1E3.800A61FD@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=aferber@techfak.uni-bielefeld.de \
--cc=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox