From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "David S. Miller" <davem@redhat.com>,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: Various 802.1Q VLAN driver patches.
Date: Fri, 01 Mar 2002 14:17:22 -0500 [thread overview]
Message-ID: <3C7FD3C2.9674ADD7@mandrakesoft.com> (raw)
In-Reply-To: <20020301.072831.120445660.davem@redhat.com> <3C7FA81A.3070602@candelatech.com>
Ben Greear wrote:
> --- linux-2.4.16/drivers/net/eepro100.c Mon Nov 12 18:47:18 2001
> +++ linux/drivers/net/eepro100.c Tue Dec 18 11:36:11 2001
> @@ -510,12 +510,12 @@
> static const char i82557_config_cmd[CONFIG_DATA_SIZE] = {
> 22, 0x08, 0, 0, 0, 0, 0x32, 0x03, 1, /* 1=Use MII 0=Use AUI */
> 0, 0x2E, 0, 0x60, 0,
> - 0xf2, 0x48, 0, 0x40, 0xf2, 0x80, /* 0x40=Force full-duplex */
> + 0xf2, 0x48, 0, 0x40, 0xfa, 0x80, /* 0x40=Force full-duplex */
> 0x3f, 0x05, };
> static const char i82558_config_cmd[CONFIG_DATA_SIZE] = {
> 22, 0x08, 0, 1, 0, 0, 0x22, 0x03, 1, /* 1=Use MII 0=Use AUI */
> 0, 0x2E, 0, 0x60, 0x08, 0x88,
> - 0x68, 0, 0x40, 0xf2, 0x84, /* Disable FC */
> + 0x68, 0, 0x40, 0xfa, 0x84, /* Disable FC */
> 0x31, 0x05, };
hmmm. hmmm. hmmm.
I am sorely tempted to drop this patch, simply because it's changing one
magic number to another. One key question I have is, what the fsck does
this patch really do??? If it turns on VLAN [de-]tagging
unconditionally, for example, that's unacceptable.
Comments and insight requested, and appreciated.
Jeff
--
Jeff Garzik |
Building 1024 |
MandrakeSoft | Choose life.
next prev parent reply other threads:[~2002-03-01 19:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 15:28 [BETA-0.93] Fourth test release of Tigon3 driver David S. Miller
2002-03-01 16:11 ` Various 802.1Q VLAN driver patches Ben Greear
2002-03-01 16:11 ` David S. Miller
2002-03-01 16:27 ` Various 802.1Q VLAN driver patches. [try2] Ben Greear
2002-03-01 16:30 ` Matti Aarnio
2002-03-01 16:33 ` Randy.Dunlap
2002-03-01 16:42 ` Jeff Garzik
2002-03-01 17:14 ` Various 802.1Q VLAN driver patches. [try3] Ben Greear
2002-03-01 19:24 ` Jeff Garzik
2002-03-01 16:35 ` Various 802.1Q VLAN driver patches. [try2] Jeff Garzik
2002-03-01 16:46 ` Andreas Ferber
2002-03-01 18:45 ` Andrew Morton
2002-03-01 18:50 ` David S. Miller
2002-03-01 19:02 ` Jeff Garzik
2002-03-01 21:00 ` Alan Cox
2002-03-01 20:53 ` Jeff Garzik
2002-03-01 21:10 ` David S. Miller
2002-03-01 19:09 ` Jeff Garzik
2002-03-01 20:34 ` Andreas Ferber
2002-03-01 20:51 ` Jeff Garzik
2002-03-01 21:19 ` Ben Greear
2002-03-01 21:19 ` David S. Miller
2002-03-01 21:51 ` Andreas Ferber
2002-03-01 16:40 ` David S. Miller
2002-03-01 19:17 ` Jeff Garzik [this message]
2002-03-01 19:44 ` Various 802.1Q VLAN driver patches Patrick Schaaf
2002-03-01 19:43 ` Jeff Garzik
2002-03-03 20:16 ` Teodor Iacob
2002-03-01 20:27 ` Donald Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C7FD3C2.9674ADD7@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox