Re: Various 802.1Q VLAN driver patches. [try3]

[Jeff Garzik <jgarzik@mandrakesoft.com>]

Ben Greear wrote:
> --- linux/drivers/net/tulip/interrupt.c Fri Nov  9 22:45:35 2001
> +++ linux.dev/drivers/net/tulip/interrupt.c     Tue Dec 11 09:24:36 2001
> @@ -128,8 +128,8 @@
>                                    dev->name, entry, status);
>                 if (--rx_work_limit < 0)
>                         break;
> -               if ((status & 0x38008300) != 0x0300) {
> -                       if ((status & 0x38000300) != 0x0300) {
> +               if ((status & (0x38000000 | RxDescFatalErr | RxWholePkt)) != RxWholePkt) {
> +                       if ((status & (0x38000000 | RxWholePkt)) != RxWholePkt) {
>                                 /* Ingore earlier buffers. */
>                                 if ((status & 0xffff) != 0x7fff) {
>                                         if (tulip_debug > 1)
> @@ -155,10 +155,10 @@
>                         struct sk_buff *skb;
> 
>  #ifndef final_version
> -                       if (pkt_len > 1518) {
> +                       if (pkt_len > 1522) {
>                                 printk(KERN_WARNING "%s: Bogus packet size of %d (%#x).\n",
>                                            dev->name, pkt_len, pkt_len);
> -                               pkt_len = 1518;
> +                               pkt_len = 1522;
>                                 tp->stats.rx_length_errors++;
>                         }


Tulip handles fragmented packets by choking hard.  I'll probably copy
the fragmented-packed slow path from 8139cp.c, which will change this
patch immensely.

The REAL vlan tulip patch will look almost exactly like the 8139cp patch
in 2.5.6-pre2.

	Jeff




-- 
Jeff Garzik      |
Building 1024    |
MandrakeSoft     | Choose life.