Re: [PATCH] IBM Lanstreamer bugfixes (round 3)

David Dillow
2002-03-04T19:04:10Z

Jeff Garzik wrote:
>
> David Dillow wrote:
> > Right, I was talking more about the cache line size... is it sufficient
> > for that?
>
> pci_enable_device doesn't touch PCI_COMMAND_INVALIDATE either, on most
> platforms (particularly ia32, i.e. the popular one :))

Doh! I see my mistake; I was reading pdev_enable_device() which sets it
to L1_CACHE_BYTES. And a quick grep shows me that it is called from
pci_assign_unassigned_resources(), which is not called on ia32 as far as
I can see....

This seems to be a common thing to set; shouldn't we have a helper for
it as well, or have pci_enable_device() do it?

Thanks,
Dave Dillow
dillowd@y12.doe.gov