Re: [PATCH] IBM Lanstreamer bugfixes (round 3)

David Dillow
2002-03-04T18:47:57Z

Jeff Garzik wrote:
>
> David Dillow wrote:
> >
> > Jeff Garzik wrote:
> > > Set cache line size just like drivers/net/acenic.c does, and enable
> > > memory-write-invalidate...
> >
> > Does this mean the setup pci_enable_device() does on the cache line size
> > is not sufficient?
>
> pci_enable_device doesn't touch the PCI_COMMAND_INVALIDATE bit at all...

Right, I was talking more about the cache line size... is it sufficient
for that?

As for PCI_COMMAND_INVALIDATE, what does that do for me; my PCI spec
isn't handy....

> > I ask, because I've been relying on it for a driver I'm working on;
> > should I be setting this as acenic does? It would seem that this is
> > something many drivers would need to do...
>
> Yes, acenic is the code to copy, for setting that up.

INVALIDATE, or cache line size?

Thanks,
Dave Dillow
dillowd@y12.doe.gov