From: Jim Cromie <jcromie@divsol.com>
To: linux-kernel@vger.kernel.org
Subject: newbie PATCH: add MODULE_AUTHORS_VERSION macro
Date: Tue, 05 Mar 2002 17:17:49 -0700 [thread overview]
Message-ID: <3C85602D.2090809@divsol.com> (raw)
I humbly submit for your consideration: (please cc, im not subscribed)
[jimc@groucho linux]$ diff -u module.h module.h.new
--- module.h Wed Feb 27 04:22:33 2002
+++ module.h.new Tue Mar 5 15:39:39 2002
@@ -206,6 +206,10 @@
const char __module_author[] __attribute__((section(".modinfo"))) =
\
"author=" name
+#define MODULE_AUTHORS_VERSION(name) \
+const char __module_authors_version[]
__attribute__((section(".modinfo"))) = \
+"authors_version=" name
+
#define MODULE_DESCRIPTION(desc) \
const char __module_description[] __attribute__((section(".modinfo")))
= \
"description=" desc
intent is to make more info available to modinfo.
hopefully the macro name is good enough to make this obvious,
ie distinguish it from MODVERSIONS etc..
Im slightly puzzled why its not already there, (it makes me think Im
missing something),
but I did the search (this isnt same as AUTHOR printk thread (83) from
last summer),
so what the heck ...
assuming this patch is accepted, should I ? (being an optimist here)?
1. grep sources and patch modules which have a VERSION of some sort, like
arch/i386/kernel/mtrr.c:#define MTRR_VERSION "1.40 (20010327)"
arch/i386/kernel/microcode.c:#define MICROCODE_VERSION "1.09"
ie should i do the janitor work, or leave it to authors/maintainers ?
case-by-case ?
2. or should I try to devise a better macro that slaps together __FILE__
and "_VERSION" to
automatically provide the macro definitions created by the above #defines.
This could be mis-used where filename != module-name, unless the macro,
when cppd in,
can selectively undef itself. ( this option is mostly food for thought,
dunno if its practical )
3. modinfo patches ?
next reply other threads:[~2002-03-06 0:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-06 0:17 Jim Cromie [this message]
2002-03-06 4:04 ` newbie PATCH: add MODULE_AUTHORS_VERSION macro Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C85602D.2090809@divsol.com \
--to=jcromie@divsol.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox