Re: [PATCH] 2.5.6-pre2 IDE cleanup 16

benh
2002-03-06T09:16:38Z

>> I intend to kill the largely overdesigned taskfile stuff. It's broken
>> by design to provide this micro level of device access to *anybody*.
>> Operating systems should try to present the functionality of devices
>> in a convenient way to the user and not just mapp it directly to
>> user space.
>
>Martin - please go and use a macintosh for 8 weeks then come back. The
>unix philosophy is make the simple things easy make the complex possible.
>Without that low level IDE access you might as well stop hacking on the IDE
>code because eventually nobody will be able to use your IDE code anyway

I would add to that than rather than killing the taskfile stuff, it
should instead be generalized and any IDE access be done via a taskfile.

I don't comment on the actual implementation quality as I didn't look
into it closely, but the point of passing requests as taskfile's
down to the lowest level driver allow more consistency between the
various pieces of the driver, more easily hooking of the low level
taskfile "apply" code to accomodate MMIO or strangely mapped IDE
controllers, etc...

Alan: BTW, Apple's Darwin has a nice ATA layer implementation that
happens to be completely taskfile based :) Ask Andre what he thinks
about their ATA & SCSI layer, except from bloat due to their C++
implementation, their overall design is actually really nice !

Ben.