From: Martin Dalecki <dalecki@evision-ventures.com>
To: Zwane Mwaikambo <zwane@linux.realnet.co.sz>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH][2.5] BUG check in elevator.c:237
Date: Fri, 08 Mar 2002 14:57:49 +0100 [thread overview]
Message-ID: <3C88C35D.5030008@evision-ventures.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0203081443360.5383-100000@netfinity.realnet.co.sz>
Zwane Mwaikambo wrote:
> Ok cool, regarding the ide-cd current problem, i still don't see how
> moving it to a BH would help in this case, the only difference i can see
> is that the ISR won't have to be so heavy and we can get more interrupt
> handling done (assuming the BH processing keeps up). The problem isn't
> that the read_intr is preempting other code and injecting already active
> requests into the queue, but that ide-cd is allowing running requests to
> be sent multiple times.
Yeep...
> If you can just explain marginally a possible workaround other than the
> kludge i diffed up i can try investigating further.
Actually I have right now no *precise* idea (please note the difference
between *no idea* and *no precise idea*) about the optimal fix.
However making things leaner in first step may give you direct insight
into the proper solution as a side effect (OK. I know this is a bit
philosophing, but this method works really frequently... it's called
deduction...).
And it may actually turn out that the diff could be shorter
as some wordish explanation ;-).
next prev parent reply other threads:[~2002-03-08 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-08 11:00 [PATCH][2.5] BUG check in elevator.c:237 Zwane Mwaikambo
2002-03-08 11:59 ` Martin Dalecki
2002-03-08 11:57 ` Zwane Mwaikambo
2002-03-08 12:19 ` Zwane Mwaikambo
2002-03-08 12:36 ` Martin Dalecki
2002-03-08 12:29 ` Zwane Mwaikambo
2002-03-08 12:49 ` Martin Dalecki
2002-03-08 12:50 ` Zwane Mwaikambo
2002-03-08 13:57 ` Martin Dalecki [this message]
2002-03-11 9:44 ` Jens Axboe
2002-03-11 10:22 ` Martin Dalecki
2002-03-11 11:13 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C88C35D.5030008@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox