Re: [patch] My AMD IDE driver, v2.7

Jeff Garzik
2002-03-12T02:23:35Z

Linus Torvalds wrote:

>
>On Mon, 11 Mar 2002, Jeff Garzik wrote:
>
>>Linus, would it be acceptable to you to include an -optional- filter for
>>ATA commands? There is definitely a segment of users that would like to
>>firewall their devices, and I think (as crazy as it may sound) that
>>notion is a valid one.
>>
>
>I'd rather have the rule that you can turn off this feature altogther: if
>the command is so esoteric that it's not part of the regular commands we
>can generate on our own, 99% of all people probably aren't even interested
>in it.
>
Are we talking about the same thing or different things?

If filtering is done, I agree the filter feature is disable-able if the
kernel builder / sysadmin desires such. Disable the filter by default,
if that's your fancy. But let us filter. :)

>If the command is useful on its own, and has a generic meaning (ie across
>a large subset of users), then I think the kernel should support it
>through a _real_ interface, not through some "pass user data though
>inscathed" thing. Because that generic meaning probably exists even
>outside ATA drives.
>
Let me first agree on a point, to get that out of the way. I agree
there is generic meaning outside of ATA drives,for most of the ATA[PI]
commands. Further, I hope you know by now I agree with your taste in
kernel interfaces :)

First, for verification of the driver, it's darned useful to be able to
issue ATA commands from userspace. But since we're being generic, let's
just call them device commands, and imagine SCSI perhaps playing in this
playground too.

Second, if you are issuing device commands from userspace, you need to
deal with synchronization with the commands being issued from kernel space.

Third, if you have synchronization, that's a good and easy point to add
-optional- filtering.

Now... the overall point I am trying to sell is... IFF certain
lesser-used device commands are primarily issued from userspace, and IFF
it is not reasonable to create a new kernel interface, is it not
reasonable to be able to issue raw device commands from userspace? Just
the verification case alone seems like a strong argument.

Call it device_command not ata_command if you want, and add SCSI
support. Passing in raw device_commands from userspace is useful, IMO.
Throw in filtering of those commands, and life is golden for everybody
AFAICS. There is no need to be ATA specific with these goals...

Jeff