public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: suparna@in.ibm.com
Cc: Jens Axboe <axboe@suse.de>,
	linux-kernel@vger.kernel.org, torvalds@transmeta.com,
	andre@linux-ide.org, bcrl@redhat.com
Subject: Re: 2.5.6: ide driver broken in PIO mode
Date: Thu, 14 Mar 2002 10:42:40 -0800	[thread overview]
Message-ID: <3C90EF20.CB3A4415@zip.com.au> (raw)
In-Reply-To: <Pine.LNX.4.21.0203131339050.26768-100000@serv> <a6o30m$25j$1@penguin.transmeta.com> <20020313203408.GD20220@suse.de>, <20020313203408.GD20220@suse.de>; from axboe@suse.de on Wed, Mar 13, 2002 at 09:34:08PM +0100 <20020314213611.A1884@in.ibm.com>

Suparna Bhattacharya wrote:
> 
> ...
> However, the latest code I have also covers the avoidance of bv_len,
> bv_offset modifications by the block layer, which I'd been
> concerned about for quite a while and ought to have done something about
> much sooner ;)

urgh.  I didn't know there was a risk of this.

I'm using bv_offset and bv_len in the bi_end_io handler to work out
whether to unlock the final page in the multipage BIO.

That can probably be avoided, but it would be better if these
can be left alone, or at least, restored to their original value
before returning the BIO to whoever created it.

I'm also using bi_private, under the assumption that the ownership
rules for that are analogous to buffer_head.b_private.   Is this
correct?   Who owns bi_private?


-

  reply	other threads:[~2002-03-14 18:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-13 13:05 2.5.6: ide driver broken in PIO mode Roman Zippel
2002-03-13 17:41 ` Linus Torvalds
2002-03-13 18:14   ` Andre Hedrick
2002-03-13 20:06     ` Andrew Morton
2002-03-13 22:37       ` Alan Cox
2002-03-14  5:21         ` Andre Hedrick
2002-03-13 20:37     ` Jens Axboe
2002-03-14  5:56       ` Andre Hedrick
2002-03-13 20:34   ` Jens Axboe
2002-03-13 22:09     ` Martin Dalecki
2002-03-14 16:06     ` Suparna Bhattacharya
2002-03-14 18:42       ` Andrew Morton [this message]
2002-03-14 18:50         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C90EF20.CB3A4415@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=andre@linux-ide.org \
    --cc=axboe@suse.de \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suparna@in.ibm.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox